All of lore.kernel.org
 help / color / mirror / Atom feed
From: jes.sorensen@gmail.com
To: NeilBrown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Can we deprecate ioctl(RAID_VERSION)?
Date: Wed, 05 Apr 2017 13:55:34 -0400	[thread overview]
Message-ID: <wrfjvaqid9ih.fsf@gmail.com> (raw)

Hi Neil,

Looking through the code in mdadm, I noticed a number of cases calling
ioctl(RAID_VERSION). At first I had it confused with metadata version,
but it looks like RAID_VERSION will always return 90000 if it's a valid
raid device.

In the cases we want to confirm the fd is a valid raid array,
ioctl(GET_ARRAY_INFO) should do, or sysfs_read(GET_VERSION).

Am I missing something obvious here, or do you see any reason for
leaving this around?

Thanks,
Jes

             reply	other threads:[~2017-04-05 17:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 17:55 jes.sorensen [this message]
2017-04-05 19:02 ` Can we deprecate ioctl(RAID_VERSION)? jes.sorensen
2017-04-05 22:32   ` NeilBrown
2017-04-06 15:31     ` Jes Sorensen
2017-04-06 18:10       ` Coly Li
2017-04-06 18:14         ` Jes Sorensen
2017-04-07  3:54           ` Coly Li
2017-04-07 14:54             ` Jes Sorensen
2017-04-06 22:44       ` NeilBrown
2017-04-07 15:55         ` jes.sorensen
2017-04-09 23:01           ` NeilBrown
2017-04-10  9:26             ` Nix
2017-04-11 14:46             ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjvaqid9ih.fsf@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.