From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Barry Day <briselec@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: rtl8xxxu: tx rate reported before set
Date: Mon, 28 Nov 2016 07:24:39 -0500 [thread overview]
Message-ID: <wrfjvav7rdvc.fsf@redhat.com> (raw)
In-Reply-To: <20161128115312.5FE3B6114D@smtp.codeaurora.org> (Kalle Valo's message of "Mon, 28 Nov 2016 11:53:12 +0000 (UTC)")
Kalle Valo <kvalo@codeaurora.org> writes:
> Barry Day <briselec@gmail.com> wrote:
>> Move the dev_info call that attempts to show the rate used before it is set.
>>
>> Signed-off-by: Barry Day <briselec@gmail.com>
>
> Jes, I would like to take this directly to fix the compiler warning. Also I'll
> change the commit log to:
Kalle,
I'm totally fine with this, please go ahead.
Barry thanks for fixing this.
Cheers,
Jes
> rtl8xxxu: tx rate reported before set
>
> Move the dev_info call that attempts to show the rate used before it is set.
> Fixes a compiler warning:
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function
> 'rtl8xxxu_fill_txdesc_v2':
> include/linux/device.h:1214:36: warning: 'rate' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
>
> Fixes: b4c3d9cfb607 ("rtl8xxxu: Pass tx_info to fill_txdesc in order
> to have access to retry count")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Barry Day <briselec@gmail.com>
next prev parent reply other threads:[~2016-11-28 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 2:12 [PATCH] rtl8xxxu: tx rate reported before set Barry Day
2016-11-28 11:53 ` Kalle Valo
[not found] ` <20161128115312.5FE3B6114D@smtp.codeaurora.org>
2016-11-28 12:24 ` Jes Sorensen [this message]
2016-11-28 15:37 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjvav7rdvc.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=briselec@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.