From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: Xiao Ni <xni@redhat.com>, linux-raid <linux-raid@vger.kernel.org>,
yizhan@redhat.com
Subject: Re: Bad raid0 bio too large problem
Date: Tue, 22 Sep 2015 12:07:09 -0400 [thread overview]
Message-ID: <wrfjvbb28mky.fsf@redhat.com> (raw)
In-Reply-To: <wrfjoagucvyq.fsf@redhat.com> (Jes Sorensen's message of "Tue, 22 Sep 2015 11:30:53 -0400")
Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> Hi Neil,
>
> I think we have some bad side effects with this patch:
>
> commit 199dc6ed5179251fa6158a461499c24bdd99c836
> Author: NeilBrown <neilb@suse.com>
> Date: Mon Aug 3 13:11:47 2015 +1000
>
> md/raid0: update queue parameter in a safer location.
>
> When a (e.g.) RAID5 array is reshaped to RAID0, the updating
> of queue parameters (e.g. max number of sectors per bio) is
> done in the wrong place.
> It should be part of ->run, but it is actually part of ->takeover.
> This means it happens before level_store() calls:
>
> blk_set_stacking_limits(&mddev->queue->limits);
>
> Running the '03r0assem' test suite fills my kernel log with output like
> below. Yi Zhang also had issues where writes failed too.
>
> robably something we need to resolve for 4.2-final or revert the
> offending patch.
Obviously I meant 4.3 here :)
Jes
next prev parent reply other threads:[~2015-09-22 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 15:30 Bad raid0 bio too large problem Jes Sorensen
2015-09-22 16:07 ` Jes Sorensen [this message]
2015-09-23 2:25 ` Neil Brown
2015-09-23 11:18 ` Jes Sorensen
2015-09-23 11:20 ` Jes Sorensen
2015-09-23 11:42 ` Jes Sorensen
2015-09-24 2:53 ` Neil Brown
2015-09-24 8:48 ` Xiao Ni
2015-09-24 12:59 ` Jes Sorensen
2015-09-25 4:23 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjvbb28mky.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=xni@redhat.com \
--cc=yizhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.