Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211)

[Jes Sorensen <Jes.Sorensen@redhat.com>]

Jes Sorensen <Jes.Sorensen@redhat.com> writes:
> Johannes Berg <johannes@sipsolutions.net> writes:
>>>         sta_priv->short_preamble = false;
>>
>> I don't think there's any need to track it, especially since you only
>> use it in TX where you have the TX info data about it.
>
> Oh, I hadn't spotted that information in struct tx_info - in that case I
> ought to be able to get rid of this one.

I went back and looked at this, and now I remember why I wrote the code
the way I did. The Realtek firmware handles rate control, so once I set
IEEE80211_HW_HAS_RATE_CONTROL, I never see
rate_flags & IEEE80211_TX_RC_USE_SHORT_PREAMBLE nor
tx_info->control_short_preamble.  In order to know whether to tell the
firmware to request short preamble or not, I needed to track whether the
sta supports it.

Do you have a suggestion for how to handle this in a better way?

Cheers,
Jes