All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Pawel Baldysiak <pawel.baldysiak@intel.com>
Cc: linux-raid@vger.kernel.org, artur.paszkiewicz@intel.com,
	aleksey.obitotskiy@intel.com, tomasz.majchrzak@intel.com
Subject: Re: [PATCH] IMSM: retry reading sync_completed during reshape
Date: Thu, 19 May 2016 10:45:39 -0400	[thread overview]
Message-ID: <wrfjwpmqw1gs.fsf@redhat.com> (raw)
In-Reply-To: <146348428075.32064.12075746168157997590.stgit@gklab-154-222.intel.com> (Pawel Baldysiak's message of "Tue, 17 May 2016 13:24:41 +0200")

Pawel Baldysiak <pawel.baldysiak@intel.com> writes:
> The sync_completed after restarting a reshape
> (for example - after reboot) is set to "delayed" until
> mdmon changes the state. Mdadm does not wait for that change with
> old kernels. If this condition occurs - it exits and reshape
> is not continuing. This patch adds retry of reading sync_complete
> with a delay. It gives time for mdmon to change the "delayed" state.
>
> Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
> ---
>  super-intel.c |   17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)

Hi Pawel,

Applied, thanks!

I have to admit I don't like this kind of fixes very much, delaying and
hoping for something to happen in time, but with the APIs we have it's
probably the best we can do.

Cheers,
Jes

      reply	other threads:[~2016-05-19 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 11:24 [PATCH] IMSM: retry reading sync_completed during reshape Pawel Baldysiak
2016-05-19 14:45 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjwpmqw1gs.fsf@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=aleksey.obitotskiy@intel.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=pawel.baldysiak@intel.com \
    --cc=tomasz.majchrzak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.