From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Krzysztof Konopko <kris@konagma.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: Fix sparse warnings
Date: Fri, 12 Dec 2014 13:52:35 -0500 [thread overview]
Message-ID: <wrfjwq5wwvik.fsf@redhat.com> (raw)
In-Reply-To: <548B2752.7030607@lwfinger.net> (Larry Finger's message of "Fri, 12 Dec 2014 11:35:14 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 12/12/2014 05:35 AM, Krzysztof Konopko wrote:
>> I was hunting particularly for inconsistencies with `sparse` and came
>> across this one. But I dug a bit further and I wonder why the driver is
>> not using standard stuff like the one in `include/linux/ieee80211.h`
>> where any data wider than one byte is clearly declared as __le<nn>?
>
> That is a good question. One possibility is that those definitions do
> not exist on some of the older kernels that Realtek supports. They
> generally work with 2.6.18 and newer.
The reason the 8723au driver doesn't use the defines from there is that
in ieee80211.h they are part of struct ieee80211_mgmt, while the 8723au
driver access the addba etc. elements without the full struct in place.
Jes
next prev parent reply other threads:[~2014-12-12 18:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 22:23 [PATCH] staging: rtl8723au: Fix sparse warnings Krzysztof Konopko
2014-12-11 23:53 ` Larry Finger
2014-12-12 11:35 ` Krzysztof Konopko
2014-12-12 13:24 ` Johannes Berg
2014-12-12 17:10 ` Jes Sorensen
2014-12-12 17:35 ` Larry Finger
2014-12-12 18:52 ` Jes Sorensen [this message]
2014-12-12 22:55 ` Krzysztof Konopko
2014-12-15 15:36 ` Jes Sorensen
2014-12-12 22:50 ` Krzysztof Konopko
2014-12-13 3:18 ` Larry Finger
2014-12-12 12:52 ` Dan Carpenter
2014-12-12 16:43 ` Larry Finger
2014-12-12 22:30 ` Krzysztof Konopko
2014-12-12 17:12 ` Jes Sorensen
2014-12-12 22:34 ` Krzysztof Konopko
2014-12-12 22:58 ` Krzysztof Konopko
2014-12-13 6:43 ` Joe Perches
2014-12-15 15:02 ` Krzysztof Konopko
2014-12-15 15:46 ` Jes Sorensen
2014-12-15 15:39 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjwq5wwvik.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kris@konagma.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.