From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: "Maxin B. John" <maxin.john@gmail.com>
Cc: linux-raid@vger.kernel.org, "Maxin B. John" <maxin.john@intel.com>
Subject: Re: [PATCH] Makefile: make the CC definition conditional
Date: Mon, 08 Feb 2016 10:55:05 -0500 [thread overview]
Message-ID: <wrfjy4avfb8m.fsf@redhat.com> (raw)
In-Reply-To: <1454925569-6840-1-git-send-email-maxin.john@gmail.com> (Maxin B. John's message of "Mon, 8 Feb 2016 11:59:29 +0200")
"Maxin B. John" <maxin.john@gmail.com> writes:
> From: "Maxin B. John" <maxin.john@intel.com>
>
> By hardcoding CC's definition in the Makefile, all the external gcc
> parameters set by tune settings are lost. This causes compile failure
> with x32 toolchain
>
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied!
Thanks,
Jes
> diff --git a/Makefile b/Makefile
> index fd79cfb..5fd7f16 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,7 +41,7 @@ KLIBC=/home/src/klibc/klibc-0.77
>
> KLIBC_GCC = gcc -nostdinc -iwithprefix include
> -I$(KLIBC)/klibc/include -I$(KLIBC)/linux/include
> -I$(KLIBC)/klibc/arch/i386/include -I$(KLIBC)/klibc/include/bits32
>
> -CC = $(CROSS_COMPILE)gcc
> +CC ?= $(CROSS_COMPILE)gcc
> CXFLAGS ?= -ggdb
> CWFLAGS = -Wall -Werror -Wstrict-prototypes -Wextra -Wno-unused-parameter
> ifdef WARN_UNUSED
prev parent reply other threads:[~2016-02-08 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 9:59 [PATCH] Makefile: make the CC definition conditional Maxin B. John
2016-02-08 15:55 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjy4avfb8m.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=maxin.john@gmail.com \
--cc=maxin.john@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.