From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Asaf Vertz <asaf.vertz@tandemg.com>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
ninox@posteo.net, tapaswenipathak@gmail.com, gdonald@gmail.com,
cmroliv@gmail.com, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar"
Date: Tue, 16 Dec 2014 07:43:34 -0500 [thread overview]
Message-ID: <wrfjy4q7pxxl.fsf@redhat.com> (raw)
In-Reply-To: <20141216091323.GA28072@ubuntu> (Asaf Vertz's message of "Tue, 16 Dec 2014 11:13:23 +0200")
Asaf Vertz <asaf.vertz@tandemg.com> writes:
> Fixed a coding style error, "foo * bar" should be "foo *bar"
>
> Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
> ---
> drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
If you want to fix the 'error' here, include it with a cleanup that also
fixes the ugly multiline arguments to the functions.
Jes
> diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c b/drivers/staging/rtl8723au/core/rtw_efuse.c
> index 81960e7..0e64d12 100644
> --- a/drivers/staging/rtl8723au/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723au/core/rtw_efuse.c
> @@ -328,12 +328,12 @@ EFUSE_Read1Byte23a(struct rtw_adapter *Adapter, u16 Address)
>
> void
> EFUSE_Write1Byte(
> - struct rtw_adapter * Adapter,
> + struct rtw_adapter *Adapter,
> u16 Address,
> u8 Value);
> void
> EFUSE_Write1Byte(
> - struct rtw_adapter * Adapter,
> + struct rtw_adapter *Adapter,
> u16 Address,
> u8 Value)
> {
> @@ -636,7 +636,7 @@ Efuse_ReadAllMap(struct rtw_adapter *pAdapter, u8 efuseType, u8 *Efuse)
> *---------------------------------------------------------------------------*/
> static void
> efuse_ShadowRead1Byte(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u16 Offset,
> u8 *Value)
> {
> @@ -648,7 +648,7 @@ efuse_ShadowRead1Byte(
> /* Read Two Bytes */
> static void
> efuse_ShadowRead2Byte(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u16 Offset,
> u16 *Value)
> {
> @@ -661,7 +661,7 @@ efuse_ShadowRead2Byte(
> /* Read Four Bytes */
> static void
> efuse_ShadowRead4Byte(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u16 Offset,
> u32 *Value)
> {
> @@ -723,7 +723,7 @@ void EFUSE_ShadowMapUpdate23a(struct rtw_adapter *pAdapter, u8 efuseType)
> *---------------------------------------------------------------------------*/
> void
> EFUSE_ShadowRead23a(
> - struct rtw_adapter * pAdapter,
> + struct rtw_adapter *pAdapter,
> u8 Type,
> u16 Offset,
> u32 *Value)
prev parent reply other threads:[~2014-12-16 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 9:13 [PATCH] staging: rtl8723au: core: fixing "foo * bar" should be "foo *bar" Asaf Vertz
2014-12-16 12:43 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjy4q7pxxl.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=asaf.vertz@tandemg.com \
--cc=cmroliv@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ninox@posteo.net \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.