From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/1] md/raid5: Use correct IS_ERR() variation on pointer check
Date: Mon, 09 Jan 2017 16:38:28 -0500 [thread overview]
Message-ID: <wrfjziizrk17.fsf@redhat.com> (raw)
In-Reply-To: <20170109213412.we7sxcivzbaiyb3i@kernel.org> (Shaohua Li's message of "Mon, 9 Jan 2017 13:34:12 -0800")
Shaohua Li <shli@kernel.org> writes:
> On Fri, Jan 06, 2017 at 07:31:35PM -0500, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> This fixes a build error on certain architectures, such as ppc64.
>
> Yep, we should use IS_ERR here, applied this. I'm curious why there is a
> compile error. The IS_ERR_VALUE casts the pointer to 'unsigned long'.
When building on ppc64 I get a -Wsign-compare build error due to -Werror.
Cheers,
Jes
prev parent reply other threads:[~2017-01-09 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 0:31 [PATCH 0/1] md/raid5 - fix build error Jes.Sorensen
2017-01-07 0:31 ` [PATCH 1/1] md/raid5: Use correct IS_ERR() variation on pointer check Jes.Sorensen
2017-01-09 21:34 ` Shaohua Li
2017-01-09 21:38 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wrfjziizrk17.fsf@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.