From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Alexander Beregalov <a.beregalov@gmail.com>,
linux-next <linux-next@vger.kernel.org>
Subject: Re: next-20091029: fs/aio.c build failure
Date: Thu, 29 Oct 2009 09:07:38 -0400 [thread overview]
Message-ID: <x493a52pcv9.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20091029130135.GL10727@kernel.dk> (Jens Axboe's message of "Thu, 29 Oct 2009 14:01:36 +0100")
Jens Axboe <jens.axboe@oracle.com> writes:
> On Thu, Oct 29 2009, Jens Axboe wrote:
>> On Thu, Oct 29 2009, Alexander Beregalov wrote:
>> > Hi
>> >
>> > fs/aio.c:1575: error: implicit declaration of function 'blk_run_address_space'
>> >
>> > CONFIG_BLOCK is not set.
>>
>> Not the first time this has happened, I think we should just pull the
>> bdi/mapping unplug functions out of CONFIG_BLOCK protection. They work
>> on the backing_dev, so they aren't inherently tied to just block IO.
>
> I committed this:
>
> http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=b9d128f1088ea5245109dfc9bbceb128b6371a77
>
> Same as the posted version, but adds the backing-dev.h include to
> fs/aio.c to make it visible as well. Passes compile/link testing here,
> for both CONFIG_BLOCk and !CONFIG_BLOCK.
Thanks for fixing that, Jens!
Acked-by: Jeff Moyer <jmoyer@redhat.com>
prev parent reply other threads:[~2009-10-29 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 12:40 next-20091029: fs/aio.c build failure Alexander Beregalov
2009-10-29 12:56 ` Jens Axboe
2009-10-29 13:01 ` Jens Axboe
2009-10-29 13:07 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x493a52pcv9.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=a.beregalov@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.