Re: [patch] xfs/259 - inherit $_fs_has_crcs

[Jeff Moyer <jmoyer@redhat.com>]

Brian Foster <bfoster@redhat.com> writes:

>> > @@ -72,7 +72,7 @@ for del in $sizes_to_check; do
>> >  	lofile=$(losetup -f)
>> >  	losetup $lofile "$testfile"
>> >  	"$MKFS_XFS_PROG" -l size=32m -b size=$blocksize $lofile \
>> > -					>/dev/null || echo "mkfs failed!"
>> > +			 -m crc=$_fs_has_crcs>/dev/null || echo "mkfs failed!"
>> 
>> It occurs to me that this may break on systems using a mkfs.xfs that
>> does not support the "-m crc" option.  Is there a standard way to test
>> for such things?
>> 
>
> I suppose we could add a $crc_options to the mkfs command line that can
> be set appropriately in the if/else. If the test fs has crc support, set
> crc_options="-m crc=1". Otherwise, maybe use
> '_scratch_mkfs_xfs_supported -m crc=0' (from
> common/rc:_require_xfs_mkfs_crc()) in the else condition to either set
> crc_options="-m crc=0" or drop the option (crc_options="")?

How does one determine whether mkfs.xfs supports the crc= option?  That
was the question I tried to ask.  ;-)

> Another option could be just to unconditionally set crc=[0|1] and add a
> _require_xfs_crc() to the test, but that would just skip the test on
> older systems.

I think we can agree that would be a bad approach.  :)

-Jeff