From: Michael Stapelberg <stapelberg@debian.org>
To: linux-lvm@redhat.com
Subject: [linux-lvm] [PATCH] Use LVM_PATH instead of hard-coded /usr/sbin/lvm
Date: Wed, 14 Aug 2013 20:38:36 +0200 [thread overview]
Message-ID: <x6zjski0cz.fsf@midna.lan> (raw)
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
Hi,
I noticed that the systemd generator hardcodes /usr/sbin/lvm.
Attached you can find a patch which fixes the issue. Please merge it or
fix the issue in a different way if you prefer :). Thanks!
--
Best regards,
Michael
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: lvm_path.patch --]
[-- Type: text/x-diff, Size: 1028 bytes --]
Description: Use LVM_PATH instead of hard-coded /usr/sbin/lvm
Author: Michael Stapelberg <stapelberg@debian.org>
Last-Update: 2013-08-14
---
Index: lvm2-2.02.98/scripts/lvm2_activation_generator_systemd_red_hat.c
===================================================================
--- lvm2-2.02.98.orig/scripts/lvm2_activation_generator_systemd_red_hat.c 2013-08-14 18:44:12.005448150 +0200
+++ lvm2-2.02.98/scripts/lvm2_activation_generator_systemd_red_hat.c 2013-08-14 18:52:14.403183063 +0200
@@ -20,6 +20,7 @@
#include <sys/stat.h>
#include <fcntl.h>
#include "lvm2app.h"
+#include "lib.h" /* for LVM_PATH */
#define KMSG_DEV_PATH "/dev/kmsg"
#define LVM_CONF_USE_LVMETAD "global/use_lvmetad"
@@ -125,7 +126,7 @@
fputs("Before=local-fs.target shutdown.target\n"
"Wants=systemd-udev-settle.service\n\n"
"[Service]\n"
- "ExecStart=/usr/sbin/lvm vgchange -aay --sysinit\n"
+ "ExecStart=" LVM_PATH " vgchange -aay --sysinit\n"
"Type=oneshot\n", f);
if (fclose(f) < 0) {
next reply other threads:[~2013-08-14 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 18:38 Michael Stapelberg [this message]
2013-08-15 8:04 ` [linux-lvm] [PATCH] Use LVM_PATH instead of hard-coded /usr/sbin/lvm Peter Rajnoha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x6zjski0cz.fsf@midna.lan \
--to=stapelberg@debian.org \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.