From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f69.google.com (mail-lf0-f69.google.com [209.85.215.69]) by kanga.kvack.org (Postfix) with ESMTP id 4D3216B0069 for ; Sat, 31 Dec 2016 00:08:51 -0500 (EST) Received: by mail-lf0-f69.google.com with SMTP id x140so80554219lfa.2 for ; Fri, 30 Dec 2016 21:08:51 -0800 (PST) Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com. [2a00:1450:4010:c07::22c]) by mx.google.com with ESMTPS id 142si20636080lfe.154.2016.12.30.21.08.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Dec 2016 21:08:49 -0800 (PST) Received: by mail-lf0-x22c.google.com with SMTP id t196so246301986lff.3 for ; Fri, 30 Dec 2016 21:08:49 -0800 (PST) From: Michal Nazarewicz Subject: Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path. In-Reply-To: <87bmvtxizn.fsf@eliezer.anholt.net> References: <20161229023131.506-1-eric@anholt.net> <20161229091256.GF29208@dhcp22.suse.cz> <87wpeitzld.fsf@eliezer.anholt.net> <8737h65nr5.fsf@eliezer.anholt.net> <87bmvtxizn.fsf@eliezer.anholt.net> Date: Sat, 31 Dec 2016 06:08:45 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Eric Anholt , Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-stable , "Robin H. Johnson" , Vlastimil Babka , Marek Szyprowski On Fri, Dec 30 2016, Eric Anholt wrote: > OK, so the design is bad. When you said bug, I definitely thought you > were saying that the message shouldn't happen in the design. > > Given CMA's current design, should everyone using CMA see their logs > slowly growing with this message that is an secret code for "CMA's > design hasn't yet changed"? Just to be clear, it=E2=80=99s not CMA=E2=80=99s design; it=E2=80=99s movab= le page=E2=80=99s design that is bad (at least in the context of this discussion). But yes, because of the way movable pages are, everyone is likely to see the message. > If you want to have people be able to track how often this is > happening, let's make a perf event for it or something instead. Sure. --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbcLaFIx (ORCPT ); Sat, 31 Dec 2016 00:08:53 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:36835 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696AbcLaFIv (ORCPT ); Sat, 31 Dec 2016 00:08:51 -0500 From: Michal Nazarewicz To: Eric Anholt , Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-stable , "Robin H. Johnson" , Vlastimil Babka , Marek Szyprowski Subject: Re: [PATCH] mm: Drop "PFNs busy" printk in an expected path. In-Reply-To: <87bmvtxizn.fsf@eliezer.anholt.net> Organization: http://mina86.com/ References: <20161229023131.506-1-eric@anholt.net> <20161229091256.GF29208@dhcp22.suse.cz> <87wpeitzld.fsf@eliezer.anholt.net> <8737h65nr5.fsf@eliezer.anholt.net> <87bmvtxizn.fsf@eliezer.anholt.net> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/26.0.50.2 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:161231:eric@anholt.net::PKP2PmJ1wsxwofiz:000MAX X-Hashcash: 1:20:161231:mhocko@kernel.org::S2dB6mbWLovZ+ubP:000000000000000000000000000000000000000000000/Iv X-Hashcash: 1:20:161231:linux-kernel@vger.kernel.org::SSORB/429yTfw45H:0000000000000000000000000000000001KYg X-Hashcash: 1:20:161231:m.szyprowski@samsung.com::Y1EkdULZkqekVNeA:00000000000000000000000000000000000003qxZ X-Hashcash: 1:20:161231:vbabka@suse.cz::9IluTsASOW7Iodnp:00046es X-Hashcash: 1:20:161231:robbat2@orbis-terrarum.net::+KFnnGrt3BNyqXZF:000000000000000000000000000000000005+D0 X-Hashcash: 1:20:161231:linux-mm@kvack.org::bVuQs7WcEfnTANvc:000000000000000000000000000000000000000000045Z3 X-Hashcash: 1:20:161231:stable@vger.kernel.org::bU8EzJKwMPemevw5:000000000000000000000000000000000000000EVjv Date: Sat, 31 Dec 2016 06:08:45 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBV590KX005090 On Fri, Dec 30 2016, Eric Anholt wrote: > OK, so the design is bad. When you said bug, I definitely thought you > were saying that the message shouldn't happen in the design. > > Given CMA's current design, should everyone using CMA see their logs > slowly growing with this message that is an secret code for "CMA's > design hasn't yet changed"? Just to be clear, it’s not CMA’s design; it’s movable page’s design that is bad (at least in the context of this discussion). But yes, because of the way movable pages are, everyone is likely to see the message. > If you want to have people be able to track how often this is > happening, let's make a perf event for it or something instead. Sure. -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»