From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758728AbcGKLis (ORCPT ); Mon, 11 Jul 2016 07:38:48 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35197 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753867AbcGKLip convert rfc822-to-8bit (ORCPT ); Mon, 11 Jul 2016 07:38:45 -0400 From: Michal Nazarewicz To: Baolin Wang , balbi@kernel.org Cc: gregkh@linuxfoundation.org, eu@felipetonello.com, r.baldyga@samsung.com, dan.carpenter@oracle.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, baolin.wang@linaro.org Subject: Re: [PATCH v2] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize In-Reply-To: <2615165a391e3a7c2a75b094c39331bbce5ce850.1468205347.git.baolin.wang@linaro.org> Organization: http://mina86.com/ References: <2615165a391e3a7c2a75b094c39331bbce5ce850.1468205347.git.baolin.wang@linaro.org> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160711:linux-kernel@vger.kernel.org::55svcdQNrQIQn8hD:0000000000000000000000000000000000VaB X-Hashcash: 1:20:160711:balbi@kernel.org::V5+XvOah7WUxFru/:00b/8 X-Hashcash: 1:20:160711:dan.carpenter@oracle.com::0o6XCWwzDVVzgW2V:00000000000000000000000000000000000000Udd X-Hashcash: 1:20:160711:linux-usb@vger.kernel.org::Dm6OLsj+97NHV+xy:0000000000000000000000000000000000000tyL X-Hashcash: 1:20:160711:baolin.wang@linaro.org::ZrBP2OeDMhhCKaWt:000000000000000000000000000000000000000CESV X-Hashcash: 1:20:160711:broonie@kernel.org::oY0nDJIjyGz5umF7:00000000000000000000000000000000000000000001FzW X-Hashcash: 1:20:160711:r.baldyga@samsung.com::XrKtT35KA8VBKzvo:0000000000000000000000000000000000000000B+mk X-Hashcash: 1:20:160711:eu@felipetonello.com::LadW6ZQxWE6QdZN8:0000000000000000000000000000000000000000039rp X-Hashcash: 1:20:160711:gregkh@linuxfoundation.org::q5RIPxspJOy1pkQS:000000000000000000000000000000000001We2 X-Hashcash: 1:20:160711:baolin.wang@linaro.org::h+kNQDGU54jglgJQ:0000000000000000000000000000000000000001sRx Date: Mon, 11 Jul 2016 13:38:40 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11 2016, Baolin Wang wrote: > Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size > attribute, which means it need to align the request buffer's size to an ep's > maxpacketsize. > > Thus we add usb_ep_align_maybe() function to check if it is need to align > the request buffer's size to an ep's maxpacketsize. > > Signed-off-by: Baolin Wang > Acked-by: Michal Nazarewicz > --- > Changelog since v1: > - Remove the in_ep modification. > - Remove max_t() function. > > drivers/usb/gadget/function/f_midi.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index 58fc199..59f6278 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -359,10 +359,14 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt) > > /* allocate a bunch of read buffers and queue them all at once. */ > for (i = 0; i < midi->qlen && err == 0; i++) { > - struct usb_request *req = > - midi_alloc_ep_req(midi->out_ep, > - max_t(unsigned, midi->buflen, > - bulk_out_desc.wMaxPacketSize)); > + struct usb_request *req; > + unsigned length; > + > + length = midi->buflen < bulk_out_desc.wMaxPacketSize > + ? bulk_out_desc.wMaxPacketSize > + : usb_ep_align_maybe(midi->gadget, midi->out_ep, > + midi->buflen); As pointed out by Felipe, the packet does not need to be wMaxPacketSize so this can simply be: > + length = usb_ep_align_maybe(midi->gadget, midi->out_ep, > + midi->buflen); > + req = midi_alloc_ep_req(midi->out_ep, length); > if (req == NULL) > return -ENOMEM; > > -- > 1.7.9.5 > -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»