From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Wed, 08 Jul 2015 15:47:43 +0200 Subject: [PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check In-Reply-To: <1436346323-31593-6-git-send-email-r.baldyga@samsung.com> References: <1436346323-31593-1-git-send-email-r.baldyga@samsung.com> <1436346323-31593-6-git-send-email-r.baldyga@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 08 2015, Robert Baldyga wrote: > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga > Acked-by: Nicolas Ferre Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 4095cce0..37d414e 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, > ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc"); > > ret = of_property_read_string(pp, "name", &name); > + if (ret) { > + dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret); > + goto err; > + } > ep->ep.name = name; > > ep->ep_regs = udc->regs + USBA_EPT_BASE(i); > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Micha? ?mina86? Nazarewicz (o o) ooo +------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934134AbbGHNrt (ORCPT ); Wed, 8 Jul 2015 09:47:49 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:33913 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934027AbbGHNrr convert rfc822-to-8bit (ORCPT ); Wed, 8 Jul 2015 09:47:47 -0400 From: Michal Nazarewicz To: Robert Baldyga , gregkh@linuxfoundation.org, balbi@ti.com Cc: nicolas.ferre@atmel.com, dan.carpenter@oracle.com, sergei.shtylyov@cogentembedded.com, andrzej.p@samsung.com, m.szyprowski@samsung.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robert Baldyga Subject: Re: [PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check In-Reply-To: <1436346323-31593-6-git-send-email-r.baldyga@samsung.com> Organization: http://mina86.com/ References: <1436346323-31593-1-git-send-email-r.baldyga@samsung.com> <1436346323-31593-6-git-send-email-r.baldyga@samsung.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:150708:devel@driverdev.osuosl.org::UbBHkr2qJ/lw5GHT:0000000000000000000000000000000000001NZ X-Hashcash: 1:20:150708:sergei.shtylyov@cogentembedded.com::4piEztw++G0RjOAF:00000000000000000000000000001hX X-Hashcash: 1:20:150708:linux-usb@vger.kernel.org::TYINsfQ5uIuK/Xps:0000000000000000000000000000000000000aVy X-Hashcash: 1:20:150708:dan.carpenter@oracle.com::9mp88785oIccYfX9:000000000000000000000000000000000000016R+ X-Hashcash: 1:20:150708:nicolas.ferre@atmel.com::QTFQZREyt6x6U5k2:000000000000000000000000000000000000000u84 X-Hashcash: 1:20:150708:andrzej.p@samsung.com::cv5EnHQNM36ZqOM9:00000000000000000000000000000000000000000+TL X-Hashcash: 1:20:150708:linux-kernel@vger.kernel.org::5qyW2m9kILuPRi5K:00000000000000000000000000000000028tY X-Hashcash: 1:20:150708:balbi@ti.com::oDnP2quOD43zzyMl:000004J1L X-Hashcash: 1:20:150708:linux-arm-kernel@lists.infradead.org::vpX8QGRHVmeUyF9/:00000000000000000000000003xe7 X-Hashcash: 1:20:150708:gregkh@linuxfoundation.org::utnDENAsEkxLzDFV:000000000000000000000000000000000005/TW X-Hashcash: 1:20:150708:m.szyprowski@samsung.com::Y2VlOQ/nI410s1XC:00000000000000000000000000000000000007gED X-Hashcash: 1:20:150708:r.baldyga@samsung.com::J5IQTrqYLXjm1T+h:0000000000000000000000000000000000000000EJgt X-Hashcash: 1:20:150708:r.baldyga@samsung.com::482NKOX8xYdjOgWQ:0000000000000000000000000000000000000000KBsi Date: Wed, 08 Jul 2015 15:47:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08 2015, Robert Baldyga wrote: > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga > Acked-by: Nicolas Ferre Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 4095cce0..37d414e 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -1989,6 +1989,10 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, > ep->can_isoc = of_property_read_bool(pp, "atmel,can-isoc"); > > ret = of_property_read_string(pp, "name", &name); > + if (ret) { > + dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret); > + goto err; > + } > ep->ep.name = name; > > ep->ep_regs = udc->regs + USBA_EPT_BASE(i); > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--