From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Wed, 07 Aug 2013 14:38:06 +0200 Subject: [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory In-Reply-To: <5201172F.5050803@samsung.com> References: <1375275119-12787-1-git-send-email-m.szyprowski@samsung.com> <1375275119-12787-4-git-send-email-m.szyprowski@samsung.com> <5201172F.5050803@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 06 2013, Sylwester Nawrocki wrote: > On 08/06/2013 05:07 PM, Michal Nazarewicz wrote: >> On Tue, Aug 06 2013, Rob Herring wrote: >>>> >> +static void reserved_mem_release_device_from_dt(struct device *dev) >>>> >> +{ >>>> >> + struct reserved_mem *region = get_dma_memory_region(dev); >>>> >> + if (!region) >>>> >> + return; >>>> >> + if (!region->cma) >>> > >>> > if (region && !region->cma) >> >> !region case is handled two lines above, so no need to check if region >> is not null. > > I think Rob's suggestion was to replace two 'if' statements with a single > one, which makes sense. Ah, yes, silly me... -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Micha? ?mina86? Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo-- -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 835 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Subject: Re: [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory Date: Wed, 07 Aug 2013 14:38:06 +0200 Message-ID: References: <1375275119-12787-1-git-send-email-m.szyprowski@samsung.com> <1375275119-12787-4-git-send-email-m.szyprowski@samsung.com> <5201172F.5050803@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: In-Reply-To: <5201172F.5050803@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sylwester Nawrocki Cc: Grant Likely , Sascha Hauer , Arnd Bergmann , "devicetree-discuss@lists.ozlabs.org" , Nishanth Peethambaran , linaro-mm-sig@lists.linaro.org, Marc , Kyungmin Park , Olof Johansson , Laura Abbott , Tomasz Figa , "linux-arm-kernel@lists.infradead.org" , Marek Szyprowski List-Id: devicetree@vger.kernel.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Aug 06 2013, Sylwester Nawrocki wrote: > On 08/06/2013 05:07 PM, Michal Nazarewicz wrote: >> On Tue, Aug 06 2013, Rob Herring wrote: >>>> >> +static void reserved_mem_release_device_from_dt(struct device *dev) >>>> >> +{ >>>> >> + struct reserved_mem *region =3D get_dma_memory_region(dev); >>>> >> + if (!region) >>>> >> + return; >>>> >> + if (!region->cma) >>> > >>> > if (region && !region->cma) >> >> !region case is handled two lines above, so no need to check if region >> is not null. > > I think Rob's suggestion was to replace two 'if' statements with a single > one, which makes sense. Ah, yes, silly me... --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------------------ooO--(_)--Ooo-- --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJSAj+uAAoJECBgQBJQdR/03nwP/iHROUWM+8qvFkR3mowijtO+ BexFNOfL+JEa0UhalpiWBfyLKmR3V3q6SJlzryhRS5eyrW5T1YgwQt3FooWa86S5 nxz6YBM0Abm5I75IWs/83UdFHcnEW/C2lzPEhpKeSqP9UP9L2enAMSj39e0qCDjx CsTg5F6sXp1KbCkA83ZftwUBE0GCDzLOgZx2kttSKwQHqW4ODfEOYTUiXJGxCOf1 VDtwFYTLdjB/BomUuEUga+O4we0DxDcgZGjAUpzDsxkTLDoPqrkEj6KpE+P7uOYc YIlg4hzlv54Ya3bAcOOcagRnurJZzVmKva/XGE+bKstRm+v4m4pJrwS46o9Fy8LY BhYXtnRzckGnnvc516CEAwFrDz+jMBM3AMmE01CO8AXJf3gl3zc/q03fpTWtH5e/ KpdNPYeiQAWoCod2e3jf4qrGSaAV6unzOqQpi/1GJrz9L3B5VvitR3VQjOQIBcM4 tFlMzIM8YMJ2Y/wS5m1XQUlQ2vlkozSGeIbPoKIH1Tplwe88NvIs5h6M2YCUkPaq rvvaZD02iZI4D1tGxjAvuriqmD+nk2Jgcy+Oy+KFlBtveYvq+uraK4o5umIWIqvn yCZiowXJqzgFRxN1KlmELZnyYA62w9aiGDXh87NxrjT/p5qJ0QmWdx8P+1mIEBG8 O6BgEMTeCDsR+/FujXRZ =3vrO -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=-=-=--