From: Michal Nazarewicz <mina86@mina86.com>
To: Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Alan Stern <stern@rowland.harvard.edu>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Bin Liu <b-liu@ti.com>,
pali.rohar@gmail.com
Subject: Re: [PATCH] usb: f_mass_storage: test whether thread is running before starting another
Date: Tue, 19 Apr 2016 16:38:38 +0200 [thread overview]
Message-ID: <xa1tbn55slxt.fsf@mina86.com> (raw)
In-Reply-To: <5714A852.2040705@samsung.com>
On Mon, Apr 18 2016, Andrzej Pietrasiewicz wrote:
> The function responsible for verifying if a symlink can be made is in
> drivers/usb/gadget/configfs.c: config_usb_cfg_link()
>
> There is a comment from the author:
>
> * Also a function instance can only be linked once.
>
> This is the code fragment of interest:
>
> list_for_each_entry(f, &cfg->func_list, list) {
> if (f->fi == fi) {
> ret = -EEXIST;
> goto out;
> }
> }
Thanks for checking. This is exactly the kind of check I expected so
checking for thread not being run multiple times is enough when
configfs is in use.
Legacy gadgets may still construct crazy configurations but I’d call
that a bug in such legacy gadget.
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
prev parent reply other threads:[~2016-04-19 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 17:28 [PATCH] usb: f_mass_storage: test whether thread is running before starting another Michal Nazarewicz
2016-04-05 17:42 ` Alan Stern
2016-04-05 18:07 ` Michal Nazarewicz
2016-04-05 18:35 ` Alan Stern
2016-04-05 22:26 ` Michal Nazarewicz
2016-04-06 15:05 ` Alan Stern
2016-04-07 9:57 ` Michal Nazarewicz
2016-04-07 14:25 ` Alan Stern
2016-04-07 14:46 ` Ivaylo Dimitrov
2016-04-07 20:50 ` Ivaylo Dimitrov
2016-04-07 16:40 ` Michal Nazarewicz
2016-04-18 9:26 ` Andrzej Pietrasiewicz
2016-04-19 14:38 ` Michal Nazarewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tbn55slxt.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=andrzej.p@samsung.com \
--cc=b-liu@ti.com \
--cc=felipe.balbi@linux.intel.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.