Re: [PATCH] mm-cma-add-functions-to-get-region-pages-counters-fix-3

[Michal Nazarewicz <mina86@mina86.com>]

On Wed, Apr 08 2015, Dmitry Safonov <d.safonov@partner.samsung.com> wrote:
> Fix for the next compiler warnings:
> mm/cma_debug.c:45 cma_used_get() warn: should 'used << cma->order_per_bit' be a 64 bit type?
> mm/cma_debug.c:67 cma_maxchunk_get() warn: should 'maxchunk << cma->order_per_bit' be a 64 bit type?
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Michal Nazarewicz <mina86@mina86.com>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> Cc: Stefan Strogin <stefan.strogin@gmail.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Cc: Pintu Kumar <pintu.k@samsung.com>
> Cc: Weijie Yang <weijie.yang@samsung.com>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Vyacheslav Tyrtov <v.tyrtov@samsung.com>
> Cc: Aleksei Mateosian <a.mateosian@samsung.com>
> Cc: Sasha Levin <sasha.levin@oracle.com>
> Cc: Michal Hocko <mhocko@suse.cz>
> Signed-off-by: Dmitry Safonov <d.safonov@partner.samsung.com>
> ---
>  mm/cma_debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/cma_debug.c b/mm/cma_debug.c
> index 835e761..9459842 100644
> --- a/mm/cma_debug.c
> +++ b/mm/cma_debug.c
> @@ -42,7 +42,7 @@ static int cma_used_get(void *data, u64 *val)
>  	/* pages counter is smaller than sizeof(int) */
>  	used = bitmap_weight(cma->bitmap, (int)cma->count);
>  	mutex_unlock(&cma->lock);
> -	*val = used << cma->order_per_bit;
> +	*val = (u64)used << cma->order_per_bit;
>  
>  	return 0;
>  }
> @@ -64,7 +64,7 @@ static int cma_maxchunk_get(void *data, u64 *val)
>  		maxchunk = max(end - start, maxchunk);
>  	}
>  	mutex_unlock(&cma->lock);
> -	*val = maxchunk << cma->order_per_bit;
> +	*val = (u64)maxchunk << cma->order_per_bit;
>  
>  	return 0;
>  }
> -- 
> 2.3.5
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>