From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by kanga.kvack.org (Postfix) with ESMTP id 399D46B0038 for ; Mon, 29 Dec 2014 12:26:10 -0500 (EST) Received: by mail-wg0-f48.google.com with SMTP id y19so19414378wgg.7 for ; Mon, 29 Dec 2014 09:26:09 -0800 (PST) Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com. [2a00:1450:400c:c00::22e]) by mx.google.com with ESMTPS id ft7si17711340wjb.169.2014.12.29.09.26.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Dec 2014 09:26:09 -0800 (PST) Received: by mail-wg0-f46.google.com with SMTP id x13so19402036wgg.5 for ; Mon, 29 Dec 2014 09:26:09 -0800 (PST) From: Michal Nazarewicz Subject: Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo In-Reply-To: <54A160B6.5030605@gmail.com> References: <264ce8ad192124f2afec9a71a2fc28779d453ba7.1419602920.git.s.strogin@partner.samsung.com> <54A160B6.5030605@gmail.com> Date: Mon, 29 Dec 2014 18:26:05 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Stefan Strogin , "Stefan I. Strogin" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Joonsoo Kim , Andrew Morton , Marek Szyprowski , aneesh.kumar@linux.vnet.ibm.com, Laurent Pinchart , Pintu Kumar , Weijie Yang , Laura Abbott , Hui Zhu , Minchan Kim , Dyasly Sergey , Vyacheslav Tyrtov >> On Fri, Dec 26 2014, "Stefan I. Strogin" = wrote: >>> + if (ret) { >>> + pr_warn("%s(): cma_buffer_list_add() returned %d\n", >>> + __func__, ret); >>> + cma_release(cma, page, count); >>> + page =3D NULL; > On 12/26/2014 07:02 PM, Michal Nazarewicz wrote: >> Harsh, but ok, if you want. On Mon, Dec 29 2014, Stefan Strogin wrote: > Excuse me, maybe you could suggest how to make a nicer fallback? > Or sure OK? I would leave the allocation succeed and print warning that the debug information is invalid. You could have a =E2=80=9Cdirty=E2=80=9D flag whic= h is set if that happens (or on a partial release discussed earlier) which, if set, would add =E2=80=9CSome debug information missing=E2=80=9D message at the b= eginning of the procfs file. In my opinion CMA succeeding is more important than having correct debug information. --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751950AbaL2R0M (ORCPT ); Mon, 29 Dec 2014 12:26:12 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:37202 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbaL2R0K convert rfc822-to-8bit (ORCPT ); Mon, 29 Dec 2014 12:26:10 -0500 From: Michal Nazarewicz To: Stefan Strogin , "Stefan I. Strogin" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Joonsoo Kim , Andrew Morton , Marek Szyprowski , aneesh.kumar@linux.vnet.ibm.com, Laurent Pinchart , Pintu Kumar , Weijie Yang , Laura Abbott , Hui Zhu , Minchan Kim , Dyasly Sergey , Vyacheslav Tyrtov , Stefan Strogin Subject: Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo In-Reply-To: <54A160B6.5030605@gmail.com> Organization: http://mina86.com/ References: <264ce8ad192124f2afec9a71a2fc28779d453ba7.1419602920.git.s.strogin@partner.samsung.com> <54A160B6.5030605@gmail.com> User-Agent: Notmuch/0.19~rc1+1~g03aea4f (http://notmuchmail.org) Emacs/25.0.50.3 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:141229:zhuhui@xiaomi.com::SxtI9Zn3u0dcVFJm:00000000000000000000000000000000000000000000020J X-Hashcash: 1:20:141229:weijie.yang@samsung.com::dXpdmB4MPHMtLosU:000000000000000000000000000000000000000WCS X-Hashcash: 1:20:141229:aneesh.kumar@linux.vnet.ibm.com::Tac+2sg7MfptPlNp:00000000000000000000000000000012ka X-Hashcash: 1:20:141229:m.szyprowski@samsung.com::Hv06Hl5IjDjglLWO:00000000000000000000000000000000000000khk X-Hashcash: 1:20:141229:stefan.strogin@gmail.com::EFGAyxyHlk3X3ON+:00000000000000000000000000000000000000ksD X-Hashcash: 1:20:141229:akpm@linux-foundation.org::UyyYImpGfDV6Gvgl:0000000000000000000000000000000000001m87 X-Hashcash: 1:20:141229:s.strogin@partner.samsung.com::JK+o9FHXH+ENag5r:000000000000000000000000000000001Hdb X-Hashcash: 1:20:141229:lauraa@codeaurora.org::Q95P9qwiPuPX+Wig:00000000000000000000000000000000000000001kZi X-Hashcash: 1:20:141229:s.dyasly@samsung.com::wai3kdBkE/eq7YtU:000000000000000000000000000000000000000002ab3 X-Hashcash: 1:20:141229:minchan@kernel.org::DqlUuqwVGg5P7Y9i:00000000000000000000000000000000000000000002hbc X-Hashcash: 1:20:141229:v.tyrtov@samsung.com::q71Mqt/R5u2UqsN1:000000000000000000000000000000000000000001+lJ X-Hashcash: 1:20:141229:linux-kernel@vger.kernel.org::hNA+bIAA2cIpCXKq:0000000000000000000000000000000003FDh X-Hashcash: 1:20:141229:iamjoonsoo.kim@lge.com::GJIvCGCF/jCFZdHh:0000000000000000000000000000000000000004Wjz X-Hashcash: 1:20:141229:laurent.pinchart@ideasonboard.com::uBhJwDPzFw7zt5QI:00000000000000000000000000008QOm X-Hashcash: 1:20:141229:stefan.strogin@gmail.com::ztHWvr6VhpAngeCx:0000000000000000000000000000000000000A6R8 X-Hashcash: 1:20:141229:pintu.k@samsung.com::Wingb8Zl2FmasJ5x:000000000000000000000000000000000000000000Eu8R X-Hashcash: 1:20:141229:linux-mm@kvack.org::S0Jy3XdOujDHSrEO:0000000000000000000000000000000000000000000Em1N Date: Mon, 29 Dec 2014 18:26:05 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> On Fri, Dec 26 2014, "Stefan I. Strogin" wrote: >>> + if (ret) { >>> + pr_warn("%s(): cma_buffer_list_add() returned %d\n", >>> + __func__, ret); >>> + cma_release(cma, page, count); >>> + page = NULL; > On 12/26/2014 07:02 PM, Michal Nazarewicz wrote: >> Harsh, but ok, if you want. On Mon, Dec 29 2014, Stefan Strogin wrote: > Excuse me, maybe you could suggest how to make a nicer fallback? > Or sure OK? I would leave the allocation succeed and print warning that the debug information is invalid. You could have a “dirty” flag which is set if that happens (or on a partial release discussed earlier) which, if set, would add “Some debug information missing” message at the beginning of the procfs file. In my opinion CMA succeeding is more important than having correct debug information. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--