From: Michal Nazarewicz <mina86@mina86.com>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function
Date: Mon, 11 Nov 2013 22:13:43 +0100 [thread overview]
Message-ID: <xa1tbo1qy73s.fsf@mina86.com> (raw)
In-Reply-To: <5281390F.9080104@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
> On 11/10/2013 08:50 AM, Michal Nazarewicz wrote:
>> + if (wait_event_interruptible(epfile->wait, (ep = epfile->ep))) {
On Mon, Nov 11 2013, David Cohen wrote:
> FYI this line fails checkpatch:
> ERROR: do not use assignment in if condition
> #70: FILE: drivers/usb/gadget/f_fs.c:777:
> + if (wait_event_interruptible(epfile->wait, (ep = epfile->ep))) {
>
> total: 1 errors, 0 warnings, 121 lines checked
This is intentional.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2013-11-11 21:14 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 22:12 [PATCH v4 0/4] add gadget quirk to adapt f_fs for DWC3 David Cohen
2013-11-04 22:12 ` [PATCH v4 1/4] usb: gadget: move bitflags to the end of usb_gadget struct David Cohen
2013-11-04 22:12 ` [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget David Cohen
2013-11-05 14:50 ` Alan Stern
2013-11-05 15:08 ` David Cohen
2013-11-05 15:11 ` David Cohen
2013-11-05 15:41 ` Alan Stern
2013-11-05 18:13 ` David Cohen
2013-11-05 21:54 ` David Cohen
2013-11-05 23:45 ` [PATCH v4.1 " David Cohen
2013-11-06 16:06 ` Alan Stern
2013-11-04 22:12 ` [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-11-05 14:52 ` Alan Stern
2013-11-05 15:05 ` David Cohen
2013-11-05 15:38 ` Alan Stern
2013-11-05 18:12 ` David Cohen
2013-11-05 18:24 ` Alan Stern
2013-11-06 18:43 ` Michal Nazarewicz
2013-11-07 16:05 ` Alan Stern
2013-11-08 12:23 ` Michal Nazarewicz
2013-11-08 18:04 ` David Cohen
2013-11-05 15:15 ` Cohen, David A
2013-11-10 16:50 ` [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function Michal Nazarewicz
2013-11-10 16:50 ` [PATCH 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize Michal Nazarewicz
2013-11-11 4:01 ` David Cohen
2013-11-11 11:21 ` [PATCHv2 " Michal Nazarewicz
2013-11-11 19:12 ` David Cohen
2013-11-11 21:12 ` Michal Nazarewicz
2013-11-11 20:20 ` Alan Stern
2013-11-11 21:09 ` Michal Nazarewicz
2013-11-11 22:25 ` David Cohen
2013-11-12 15:50 ` Alan Stern
2013-11-12 18:24 ` David Cohen
2013-11-12 23:09 ` Paul Zimmerman
2013-11-12 23:43 ` David Cohen
2013-11-13 0:24 ` Paul Zimmerman
2013-11-13 15:52 ` Alan Stern
2013-11-13 21:51 ` David Cohen
2013-11-21 18:29 ` David Cohen
2013-11-11 23:15 ` David Cohen
2013-11-11 20:07 ` [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function David Cohen
2013-11-11 21:13 ` Michal Nazarewicz [this message]
2013-11-11 23:11 ` David Cohen
2013-11-04 22:12 ` [PATCH v4 4/4] usb: dwc3: add quirk USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE to gadget driver David Cohen
2013-11-04 22:17 ` [PATCH v4.1 4/4] usb: dwc3: set gadget's quirk ep_out_align_size David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tbo1qy73s.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=david.a.cohen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.