From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Wed, 08 Jul 2015 15:46:08 +0200 Subject: [PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit() In-Reply-To: <1436346323-31593-4-git-send-email-r.baldyga@samsung.com> References: <1436346323-31593-1-git-send-email-r.baldyga@samsung.com> <1436346323-31593-4-git-send-email-r.baldyga@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 08 2015, Robert Baldyga wrote: > Since maxpacket_limit was introduced all UDC drivers should use > usb_ep_set_maxpacket_limit() function instead of setting maxpacket value > manually. ep.maxpacket_limit contains actual maximum maxpacket value > supported by hardware which is needed by epautoconf. > > Signed-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/usb/isp1760/isp1760-udc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c > index 18ebf5b1..3699962 100644 > --- a/drivers/usb/isp1760/isp1760-udc.c > +++ b/drivers/usb/isp1760/isp1760-udc.c > @@ -1382,11 +1382,11 @@ static void isp1760_udc_init_eps(struct isp1760_udc *udc) > * This fits in the 8kB FIFO without double-buffering. > */ > if (ep_num == 0) { > - ep->ep.maxpacket = 64; > + usb_ep_set_maxpacket_limit(&ep->ep, 64); > ep->maxpacket = 64; > udc->gadget.ep0 = &ep->ep; > } else { > - ep->ep.maxpacket = 512; > + usb_ep_set_maxpacket_limit(&ep->ep, 512); > ep->maxpacket = 0; > list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list); > } > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Micha? ?mina86? Nazarewicz (o o) ooo +------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933361AbbGHNqS (ORCPT ); Wed, 8 Jul 2015 09:46:18 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34797 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932931AbbGHNqN convert rfc822-to-8bit (ORCPT ); Wed, 8 Jul 2015 09:46:13 -0400 From: Michal Nazarewicz To: Robert Baldyga , gregkh@linuxfoundation.org, balbi@ti.com Cc: nicolas.ferre@atmel.com, dan.carpenter@oracle.com, sergei.shtylyov@cogentembedded.com, andrzej.p@samsung.com, m.szyprowski@samsung.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robert Baldyga Subject: Re: [PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit() In-Reply-To: <1436346323-31593-4-git-send-email-r.baldyga@samsung.com> Organization: http://mina86.com/ References: <1436346323-31593-1-git-send-email-r.baldyga@samsung.com> <1436346323-31593-4-git-send-email-r.baldyga@samsung.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:150708:andrzej.p@samsung.com::HJhDVkXVBAhFWllI:00000000000000000000000000000000000000000FZM X-Hashcash: 1:20:150708:balbi@ti.com::qO+wO8TejI05BFbR:000001JJY X-Hashcash: 1:20:150708:dan.carpenter@oracle.com::8GDG71ByWOJu/lH4:000000000000000000000000000000000000013dH X-Hashcash: 1:20:150708:gregkh@linuxfoundation.org::mXdO/ZTqu9uZiUMn:000000000000000000000000000000000000zAB X-Hashcash: 1:20:150708:r.baldyga@samsung.com::l5HFul/sqC5euEeQ:000000000000000000000000000000000000000018PK X-Hashcash: 1:20:150708:linux-kernel@vger.kernel.org::B2hwF4Xv+yMeiZ1+:0000000000000000000000000000000001YtW X-Hashcash: 1:20:150708:linux-usb@vger.kernel.org::UbzRTwNkKI2SMZJY:0000000000000000000000000000000000001piT X-Hashcash: 1:20:150708:m.szyprowski@samsung.com::imQR0ipB5fOhtVTQ:00000000000000000000000000000000000002NLy X-Hashcash: 1:20:150708:devel@driverdev.osuosl.org::wKZN3fxWu8VCDy8v:0000000000000000000000000000000000020Hg X-Hashcash: 1:20:150708:linux-arm-kernel@lists.infradead.org::MANMKpQBfUGaR0X7:00000000000000000000000002RZr X-Hashcash: 1:20:150708:nicolas.ferre@atmel.com::r/cc75uQpjrMxW8Y:0000000000000000000000000000000000000049iL X-Hashcash: 1:20:150708:sergei.shtylyov@cogentembedded.com::CT9fbl/IMs62b9M8:0000000000000000000000000005hl9 X-Hashcash: 1:20:150708:r.baldyga@samsung.com::qTB65BNGCPSpVU6F:0000000000000000000000000000000000000000Er3l Date: Wed, 08 Jul 2015 15:46:08 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08 2015, Robert Baldyga wrote: > Since maxpacket_limit was introduced all UDC drivers should use > usb_ep_set_maxpacket_limit() function instead of setting maxpacket value > manually. ep.maxpacket_limit contains actual maximum maxpacket value > supported by hardware which is needed by epautoconf. > > Signed-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/usb/isp1760/isp1760-udc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c > index 18ebf5b1..3699962 100644 > --- a/drivers/usb/isp1760/isp1760-udc.c > +++ b/drivers/usb/isp1760/isp1760-udc.c > @@ -1382,11 +1382,11 @@ static void isp1760_udc_init_eps(struct isp1760_udc *udc) > * This fits in the 8kB FIFO without double-buffering. > */ > if (ep_num == 0) { > - ep->ep.maxpacket = 64; > + usb_ep_set_maxpacket_limit(&ep->ep, 64); > ep->maxpacket = 64; > udc->gadget.ep0 = &ep->ep; > } else { > - ep->ep.maxpacket = 512; > + usb_ep_set_maxpacket_limit(&ep->ep, 512); > ep->maxpacket = 0; > list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list); > } > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--