From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com ([209.85.212.169]:35332 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbbFVObn convert rfc822-to-8bit (ORCPT ); Mon, 22 Jun 2015 10:31:43 -0400 Received: by wiga1 with SMTP id a1so78747452wig.0 for ; Mon, 22 Jun 2015 07:31:42 -0700 (PDT) From: Michal Nazarewicz To: Krzysztof Opasiak , balbi@ti.com Cc: stable@vger.kernel.org, david.fisher1@synopsys.com, gregkh@linuxfoundation.org, andrzej.p@samsung.com, m.szyprowski@samsung.com, linux-usb@vger.kernel.org, Krzysztof Opasiak Subject: Re: [PATCH 3/5] usb: gadget: mass_storage: Place EXPORT_SYMBOL_GPL() after func definition In-Reply-To: <1434979163-5942-4-git-send-email-k.opasiak@samsung.com> References: <1434979163-5942-1-git-send-email-k.opasiak@samsung.com> <1434979163-5942-4-git-send-email-k.opasiak@samsung.com> Date: Mon, 22 Jun 2015 16:31:38 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jun 22 2015, Krzysztof Opasiak wrote: > EXPORT_SYMBOL_GPL() is usually placed after function definition > not before. > > Signed-off-by: Krzysztof Opasiak Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_mass_storage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c > index 19b31d7..4257238 100644 > --- a/drivers/usb/gadget/function/f_mass_storage.c > +++ b/drivers/usb/gadget/function/f_mass_storage.c > @@ -2761,12 +2761,12 @@ static void _fsg_common_remove_luns(struct fsg_common *common, int n) > common->luns[i] = NULL; > } > } > -EXPORT_SYMBOL_GPL(fsg_common_remove_luns); > > void fsg_common_remove_luns(struct fsg_common *common) > { > _fsg_common_remove_luns(common, common->nluns); > } > +EXPORT_SYMBOL_GPL(fsg_common_remove_luns); > > void fsg_common_free_luns(struct fsg_common *common) > { > -- > 1.7.9.5 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe stable" in