From: Michal Nazarewicz <mina86@mina86.com>
To: Robert Baldyga <r.baldyga@samsung.com>,
Felipe Balbi <balbi@ti.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Chuansheng Liu <chuansheng.liu@intel.com>,
balbi@ti.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
david.a.cohen@linux.intel.com
Subject: Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()
Date: Tue, 04 Mar 2014 20:53:40 +0100 [thread overview]
Message-ID: <xa1td2i14u63.fsf@mina86.com> (raw)
In-Reply-To: <20140304160620.GH15233@saruman.home>
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
>> On 03/04/2014 10:34 AM, Chuansheng Liu wrote:
>> >@@ -845,12 +845,14 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data)
>> > * we may end up with more data then user space has
>> > * space for.
>> > */
>> >- ret = ep->status;
>> >- if (io_data->read && ret > 0 &&
>> >- unlikely(copy_to_user(io_data->buf, data,
>> >- min_t(size_t, ret,
>> >- io_data->len))))
>> >- ret = -EFAULT;
>> >+ ret = ep->status;
On Tue, Mar 04 2014, Felipe Balbi wrote:
>> Why the indentation jumped suddenly to the right?
> On Tue, Mar 04, 2014 at 08:01:15PM +0300, Sergei Shtylyov wrote:
> because it was wrong before ;-)
Yep. It looks like Robert's [2e4c7553: add aio support] introduced an
if-else-if-else flow but did not indent the code and I didn't caught it
when reviewing that patch.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2014-03-04 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 7:34 [PATCH v2] usb: gadget: return the right length in ffs_epfile_io() Chuansheng Liu
2014-03-04 17:01 ` Sergei Shtylyov
2014-03-04 16:06 ` Felipe Balbi
2014-03-04 19:53 ` Michal Nazarewicz [this message]
2014-03-04 19:55 ` Felipe Balbi
2014-03-04 23:38 ` Liu, Chuansheng
2014-03-05 15:22 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1td2i14u63.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=balbi@ti.com \
--cc=chuansheng.liu@intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r.baldyga@samsung.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.