From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Wed, 08 Jul 2015 15:45:43 +0200 Subject: [PATCH v2 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call In-Reply-To: <1436346323-31593-3-git-send-email-r.baldyga@samsung.com> References: <1436346323-31593-1-git-send-email-r.baldyga@samsung.com> <1436346323-31593-3-git-send-email-r.baldyga@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 08 2015, Robert Baldyga wrote: > Function midi registers two interfaces with single set_alt() function > which means that f_midi_set_alt() is called twice when configuration > is set. That means that endpoint initialization and ep request allocation > is done two times. To avoid this problem we do such things only once, > for interface number 1 (MIDI Streaming interface). > > Signed-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_midi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index 6316aa5..4cef222 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -329,6 +329,10 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt) > unsigned i; > int err; > > + /* For Control Device interface we do nothing */ > + if (intf == 0) > + return 0; > + > err = f_midi_start_ep(midi, f, midi->in_ep); > if (err) > return err; > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Micha? ?mina86? Nazarewicz (o o) ooo +------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932790AbbGHNpx (ORCPT ); Wed, 8 Jul 2015 09:45:53 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:38517 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758259AbbGHNps convert rfc822-to-8bit (ORCPT ); Wed, 8 Jul 2015 09:45:48 -0400 From: Michal Nazarewicz To: Robert Baldyga , gregkh@linuxfoundation.org, balbi@ti.com Cc: nicolas.ferre@atmel.com, dan.carpenter@oracle.com, sergei.shtylyov@cogentembedded.com, andrzej.p@samsung.com, m.szyprowski@samsung.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robert Baldyga Subject: Re: [PATCH v2 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call In-Reply-To: <1436346323-31593-3-git-send-email-r.baldyga@samsung.com> Organization: http://mina86.com/ References: <1436346323-31593-1-git-send-email-r.baldyga@samsung.com> <1436346323-31593-3-git-send-email-r.baldyga@samsung.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:150708:m.szyprowski@samsung.com::sLDovjXxgfrPiUCA:00000000000000000000000000000000000000LWe X-Hashcash: 1:20:150708:nicolas.ferre@atmel.com::g8HObU7iXRAgxQKT:00000000000000000000000000000000000000074r X-Hashcash: 1:20:150708:devel@driverdev.osuosl.org::SjfestTIDqT9IKxr:000000000000000000000000000000000000Jsw X-Hashcash: 1:20:150708:r.baldyga@samsung.com::pcv9ZJKC6CGDA3Av:00000000000000000000000000000000000000001Bf+ X-Hashcash: 1:20:150708:linux-arm-kernel@lists.infradead.org::JnMNjS9JsY5ppdwM:00000000000000000000000002Prr X-Hashcash: 1:20:150708:balbi@ti.com::RTCkfTWQwlH1eFAI:000001n77 X-Hashcash: 1:20:150708:linux-kernel@vger.kernel.org::tDomq01jvRR6KCcA:0000000000000000000000000000000001qKC X-Hashcash: 1:20:150708:r.baldyga@samsung.com::6kiNHIhGCwmb9wLV:00000000000000000000000000000000000000002Tzo X-Hashcash: 1:20:150708:dan.carpenter@oracle.com::6ktwdtoPqK7aru2b:00000000000000000000000000000000000002RBH X-Hashcash: 1:20:150708:gregkh@linuxfoundation.org::WFXz0/TDMjb4qv0E:000000000000000000000000000000000002B+X X-Hashcash: 1:20:150708:andrzej.p@samsung.com::MKcHHRRpSz2Sgw0U:000000000000000000000000000000000000000060gj X-Hashcash: 1:20:150708:linux-usb@vger.kernel.org::CMrkEiKR/WFotihF:0000000000000000000000000000000000004hea X-Hashcash: 1:20:150708:sergei.shtylyov@cogentembedded.com::DPL8EzNNiwiNryyO:0000000000000000000000000009I6q Date: Wed, 08 Jul 2015 15:45:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 08 2015, Robert Baldyga wrote: > Function midi registers two interfaces with single set_alt() function > which means that f_midi_set_alt() is called twice when configuration > is set. That means that endpoint initialization and ep request allocation > is done two times. To avoid this problem we do such things only once, > for interface number 1 (MIDI Streaming interface). > > Signed-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_midi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index 6316aa5..4cef222 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -329,6 +329,10 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt) > unsigned i; > int err; > > + /* For Control Device interface we do nothing */ > + if (intf == 0) > + return 0; > + > err = f_midi_start_ep(midi, f, midi->in_ep); > if (err) > return err; > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--