From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Date: Fri, 24 Oct 2014 16:34:46 +0000 Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated Message-Id: List-Id: References: <1414074828-4488-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1414074828-4488-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1463193.4qGZjcvNod@avalon> In-Reply-To: <1463193.4qGZjcvNod@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-arm-kernel@lists.infradead.org > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: >> As a matter of fact, this is present in kernels earlier than 3.17 but in >> the 3.17 the code has been moved from drivers/base/dma-contiguous.c to >> mm/cma.c so this might require separate stable patch. On Fri, Oct 24 2014, Laurent Pinchart wrote: > That could be done, but I'm not sure if it's really worth it. The bug only > occurs when the CMA zone activation fails. I've ran into that case due to a > bug introduced in v3.18-rc1, but this shouldn't be the case for older kernel > versions. Fair enough. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Fri, 24 Oct 2014 18:34:46 +0200 Subject: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated In-Reply-To: <1463193.4qGZjcvNod@avalon> References: <1414074828-4488-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1414074828-4488-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1463193.4qGZjcvNod@avalon> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: >> As a matter of fact, this is present in kernels earlier than 3.17 but in >> the 3.17 the code has been moved from drivers/base/dma-contiguous.c to >> mm/cma.c so this might require separate stable patch. On Fri, Oct 24 2014, Laurent Pinchart wrote: > That could be done, but I'm not sure if it's really worth it. The bug only > occurs when the CMA zone activation fails. I've ran into that case due to a > bug introduced in v3.18-rc1, but this shouldn't be the case for older kernel > versions. Fair enough. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Micha? ?mina86? Nazarewicz (o o) ooo +------ooO--(_)--Ooo-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com [209.85.217.179]) by kanga.kvack.org (Postfix) with ESMTP id EA6F76B006C for ; Fri, 24 Oct 2014 12:34:52 -0400 (EDT) Received: by mail-lb0-f179.google.com with SMTP id l4so2854779lbv.38 for ; Fri, 24 Oct 2014 09:34:52 -0700 (PDT) Received: from mail-lb0-x236.google.com (mail-lb0-x236.google.com. [2a00:1450:4010:c04::236]) by mx.google.com with ESMTPS id ao5si7780279lbc.58.2014.10.24.09.34.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Oct 2014 09:34:51 -0700 (PDT) Received: by mail-lb0-f182.google.com with SMTP id f15so1574387lbj.41 for ; Fri, 24 Oct 2014 09:34:50 -0700 (PDT) From: Michal Nazarewicz Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated In-Reply-To: <1463193.4qGZjcvNod@avalon> References: <1414074828-4488-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1414074828-4488-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1463193.4qGZjcvNod@avalon> Date: Fri, 24 Oct 2014 18:34:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Laurent Pinchart Cc: Laurent Pinchart , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, Marek Szyprowski , Russell King - ARM Linux , Joonsoo Kim > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: >> As a matter of fact, this is present in kernels earlier than 3.17 but in >> the 3.17 the code has been moved from drivers/base/dma-contiguous.c to >> mm/cma.c so this might require separate stable patch. On Fri, Oct 24 2014, Laurent Pinchart w= rote: > That could be done, but I'm not sure if it's really worth it. The bug onl= y=20 > occurs when the CMA zone activation fails. I've ran into that case due to= a=20 > bug introduced in v3.18-rc1, but this shouldn't be the case for older ker= nel=20 > versions. Fair enough. --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756849AbaJXQey (ORCPT ); Fri, 24 Oct 2014 12:34:54 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:35210 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbaJXQew convert rfc822-to-8bit (ORCPT ); Fri, 24 Oct 2014 12:34:52 -0400 From: Michal Nazarewicz To: Laurent Pinchart Cc: Laurent Pinchart , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, Marek Szyprowski , Russell King - ARM Linux , Joonsoo Kim Subject: Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated In-Reply-To: <1463193.4qGZjcvNod@avalon> Organization: http://mina86.com/ References: <1414074828-4488-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1414074828-4488-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1463193.4qGZjcvNod@avalon> User-Agent: Notmuch/0.17+15~gb65ca8e (http://notmuchmail.org) Emacs/25.0.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd;KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:141024:linux-mm@kvack.org::uyvBoO8okx38Rge7:000000000000000000000000000000000000000000005xn X-Hashcash: 1:20:141024:linux-arm-kernel@lists.infradead.org::U1IthKglKwHs13+b:00000000000000000000000000kTG X-Hashcash: 1:20:141024:linux@arm.linux.org.uk::qzvvM2oJu6ulf8UH:0000000000000000000000000000000000000000xWQ X-Hashcash: 1:20:141024:laurent.pinchart@ideasonboard.com::XsvJ0q7hOFcSYJHq:00000000000000000000000000002q4X X-Hashcash: 1:20:141024:laurent.pinchart@ideasonboard.com::zDaQMAFvXvfa6n0A:00000000000000000000000000004SO1 X-Hashcash: 1:20:141024:linux-kernel@vger.kernel.org::Cu6mqpF3pOAB1dfv:0000000000000000000000000000000003zzc X-Hashcash: 1:20:141024:iamjoonsoo.kim@lge.com::yQMDEeFZwd8CX0oY:0000000000000000000000000000000000000006Bnx X-Hashcash: 1:20:141024:linux-sh@vger.kernel.org::K9ar/sSG8VPnVdxQ:00000000000000000000000000000000000006vDt X-Hashcash: 1:20:141024:m.szyprowski@samsung.com::dcXEOGFrRI7UEYRe:00000000000000000000000000000000000008qDp Date: Fri, 24 Oct 2014 18:34:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: >> As a matter of fact, this is present in kernels earlier than 3.17 but in >> the 3.17 the code has been moved from drivers/base/dma-contiguous.c to >> mm/cma.c so this might require separate stable patch. On Fri, Oct 24 2014, Laurent Pinchart wrote: > That could be done, but I'm not sure if it's really worth it. The bug only > occurs when the CMA zone activation fails. I've ran into that case due to a > bug introduced in v3.18-rc1, but this shouldn't be the case for older kernel > versions. Fair enough. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--