From: Michal Nazarewicz <mina86@mina86.com>
To: fdmanana@gmail.com
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
"linux-btrfs\@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] btrfs: remove dead code
Date: Wed, 01 Jan 2014 17:22:18 +0100 [thread overview]
Message-ID: <xa1tiou3d64l.fsf@mina86.com> (raw)
In-Reply-To: <CAL3q7H6ftrPyGK56i2EQ8fZaHa+RvaiFPR9SdJ4C9QrpFGPe=A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
> On Wed, Jan 1, 2014 at 5:19 AM, Michal Nazarewicz <mina86@mina86.com> wrote:
>> [commit 8185554d: fix incorrect inode acl reset] introduced a dead
>> code by adding a condition which can never be true to an else
>> branch. The condition can never be true because it is already
>> checked by a previous if statement which causes function to return.
On Wed, Jan 01 2014, Filipe David Manana wrote:
> Josef already added this patch to btrfs-next weeks ago:
>
> http://git.kernel.org/cgit/linux/kernel/git/josef/btrfs-next.git/commit/?id=c4a886e433dce2b902324a54ef2d13691a760312
Ah, sorry for the spam then.
The original thread did not mention it and this commit was not included
in linux-next's master branch.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2014-01-01 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-01 5:19 [PATCH RESEND] btrfs: remove dead code Michal Nazarewicz
2014-01-01 15:01 ` Filipe David Manana
2014-01-01 16:22 ` Michal Nazarewicz [this message]
2014-01-02 15:24 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tiou3d64l.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=clm@fb.com \
--cc=fdmanana@gmail.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.