From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933135AbdBHNUJ (ORCPT ); Wed, 8 Feb 2017 08:20:09 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35493 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753833AbdBHNQr (ORCPT ); Wed, 8 Feb 2017 08:16:47 -0500 From: Michal Nazarewicz To: Felipe Balbi , "Gustavo A. R. Silva" , gregkh@linuxfoundation.org, bhumirks@gmail.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drivers: usb: gadget: udc: add missing break in switch In-Reply-To: <87mvdxxchc.fsf@linux.intel.com> Organization: http://mina86.com/ References: <20170208072212.GA8209@embeddedgus> <87mvdxxchc.fsf@linux.intel.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/26.0.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:170208:linux-usb@vger.kernel.org::eBwZqLGA/pPmd0u7:0000000000000000000000000000000000000PBx X-Hashcash: 1:20:170208:garsilva@embeddedor.com::bFzs7FkO88UTKLs1:000000000000000000000000000000000000000La0 X-Hashcash: 1:20:170208:balbi@kernel.org::3PRUQVrPM5sD7TGt:03FNO X-Hashcash: 1:20:170208:gregkh@linuxfoundation.org::VT7rSIobzb4cpakb:0000000000000000000000000000000000051P3 X-Hashcash: 1:20:170208:bhumirks@gmail.com::mUpg5thL2YO/KSb6:000000000000000000000000000000000000000000078nA X-Hashcash: 1:20:170208:linux-kernel@vger.kernel.org::qhRuMbZBL2ksXYvB:0000000000000000000000000000000004wgV Date: Wed, 08 Feb 2017 14:16:27 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v18DKEqk029391 On Wed, Feb 08 2017, Felipe Balbi wrote: > Hi, > > "Gustavo A. R. Silva" writes: >> Add missing break in switch. >> >> Addresses-Coverity-ID: 201385 >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/usb/gadget/udc/mv_udc_core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c >> index 27ebb0d..56b3574 100644 >> --- a/drivers/usb/gadget/udc/mv_udc_core.c >> +++ b/drivers/usb/gadget/udc/mv_udc_core.c >> @@ -489,6 +489,7 @@ static int mv_ep_enable(struct usb_ep *_ep, >> break; >> case USB_ENDPOINT_XFER_CONTROL: >> ios = 1; >> + break; > > are you SURE this is supposed to have this break statement? What if we > want to initialize mult to 0 *also* for control endpoints? How did you > test this? Do you have access to Marvel's documentation for this > controller? Actually it doesn’t matter. mult is initialised to zero when it’s declared and then not touched before the switch. To improve readability, maybe something like: ---- >8 ------------------------------------------------------------ diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index d82a91bddbd9..7440c9f92ec1 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -445,7 +445,8 @@ static int mv_ep_enable(struct usb_ep *_ep, struct mv_dqh *dqh; u16 max = 0; u32 bit_pos, epctrlx, direction; - unsigned char zlt = 0, ios = 0, mult = 0; + const unsigned char zlt = 1; + unsigned char ios, mult; unsigned long flags; ep = container_of(_ep, struct mv_ep, ep); @@ -465,8 +466,6 @@ static int mv_ep_enable(struct usb_ep *_ep, * disable HW zero length termination select * driver handles zero length packet through req->req.zero */ - zlt = 1; - bit_pos = 1 << ((direction == EP_DIR_OUT ? 0 : 16) + ep->ep_num); /* Check if the Endpoint is Primed */ @@ -481,16 +480,16 @@ static int mv_ep_enable(struct usb_ep *_ep, (unsigned)bit_pos); goto en_done; } + /* Set the max packet length, interrupt on Setup and Mult fields */ + ios = 0; + mult = 0; switch (desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) { case USB_ENDPOINT_XFER_BULK: - zlt = 1; - mult = 0; + case USB_ENDPOINT_XFER_INT: break; case USB_ENDPOINT_XFER_CONTROL: ios = 1; - case USB_ENDPOINT_XFER_INT: - mult = 0; break; case USB_ENDPOINT_XFER_ISOC: /* Calculate transactions needed for high bandwidth iso */ ---- >8 ------------------------------------------------------------ -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»