From mboxrd@z Thu Jan 1 00:00:00 1970 From: mina86@mina86.com (Michal Nazarewicz) Date: Tue, 06 Aug 2013 17:07:21 +0200 Subject: [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory In-Reply-To: References: <1375275119-12787-1-git-send-email-m.szyprowski@samsung.com> <1375275119-12787-4-git-send-email-m.szyprowski@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 06 2013, Rob Herring wrote: >> +static void reserved_mem_release_device_from_dt(struct device *dev) >> +{ >> + struct reserved_mem *region = get_dma_memory_region(dev); >> + if (!region) >> + return; >> + if (!region->cma) > > if (region && !region->cma) !region case is handled two lines above, so no need to check if region is not null. >> + dma_release_declared_memory(dev); >> +} -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Micha? ?mina86? Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo-- -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 835 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Subject: Re: [PATCH v4 3/4] drivers: of: add initialization code for dma reserved memory Date: Tue, 06 Aug 2013 17:07:21 +0200 Message-ID: References: <1375275119-12787-1-git-send-email-m.szyprowski@samsung.com> <1375275119-12787-4-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring , Marek Szyprowski Cc: Grant Likely , Sascha Hauer , Arnd Bergmann , "devicetree-discuss@lists.ozlabs.org" , Nishanth Peethambaran , linaro-mm-sig@lists.linaro.org, Marc , Kyungmin Park , Sylwester Nawrocki , Olof Johansson , Laura Abbott , Tomasz Figa , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Aug 06 2013, Rob Herring wrote: >> +static void reserved_mem_release_device_from_dt(struct device *dev) >> +{ >> + struct reserved_mem *region =3D get_dma_memory_region(dev); >> + if (!region) >> + return; >> + if (!region->cma) > > if (region && !region->cma) !region case is handled two lines above, so no need to check if region is not null. >> + dma_release_declared_memory(dev); >> +} --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------------------ooO--(_)--Ooo-- --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJSAREpAAoJECBgQBJQdR/04ZIP+QHzAKxgVm1sNBOGO7x+zZVy 0jR8rumUvXD+0kcoMzV01CayQVssHeLsLOM8LwJs8VPiGi8rvu8UHpjNsuj6VYoq FCTyWksd5BZ3waSW9trniKUjzqTpVy+gsOSXpvvgAWHJiOtlRI1+rv6UL419v00a NPOTP1sFMkJio8fLu260ZL3LksLfJ543duF5RLEuwp5PE1VgUoqozcBKMjOHVjS/ vnLvlGYniSSZLJbiAxKfLO45OEfRk+rudIa9OiZAy8e6xoz3oVBTCP1ToSPxssrL Jkd+//qJ7YVip4SE+5924cgBexCOuVoKypgCwVtpWRT3Mb+wtUh1YfMYkf4A7aOC RCdvQKyNE3U79VkUEOJ5YEowcCzfu6pLKBoB1WGg4/fOdoZj1Yi+Je5XK/hBNJ2W ua/DUqxx/2qOSShHDXdukRRTkBD09mADTDnUeaS5iEv2MnzFoZlp7zhALewGUA5V e2LkoK+NA7BQtan51N3PxENBTzduE8ZvZMYsNnEalqpeSmOxDGAJ9wawifFsXDKe ACdaktqe6UiN4PDKELQ+050o7XwMyUTU7HF75ouLkHP24n657niHRBOALFdnKHD6 8ywIEQPYwBtQ1dwLWatBryO9rJWR+SkboAKvceAOYIVsOF3pTBJiNOGm4NpJ5Zhe ocxXVE47urRpASw8TjtA =x656 -----END PGP SIGNATURE----- --==-=-=-- --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=-=-=--