From: Michal Nazarewicz <mina86@mina86.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Borislav Petkov <bp@suse.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Johannes Berg <johannes.berg@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Potapenko <glider@google.com>,
Ian Abbott <abbotti@mev.co.uk>
Subject: Re: [PATCH v4 1/2] asm-generic/bug.h: declare struct pt_regs; before function prototype
Date: Tue, 23 May 2017 20:44:43 +0200 [thread overview]
Message-ID: <xa1twp972z1g.fsf@mina86.com> (raw)
In-Reply-To: <20170523160112.3446-2-abbotti@mev.co.uk>
On Tue, May 23 2017, Ian Abbott wrote:
> The declaration of `__warn()` has `struct pt_regs *regs` as one of its
> parameters. This can result in compiler warnings if `struct regs` is
> not already declared. Add an empty declaration of `struct pt_regs` to
> avoid the warnings.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> v3: Actually, there was no v1 or v2. I called this v3 to match the
> series.
> v4: Corrected 'Acked-by:' line in patch description.
> ---
> include/asm-generic/bug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> index d6f4aed479a1..87191357d303 100644
> --- a/include/asm-generic/bug.h
> +++ b/include/asm-generic/bug.h
> @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const int line);
>
> /* used internally by panic.c */
> struct warn_args;
> +struct pt_regs;
>
> void __warn(const char *file, int line, void *caller, unsigned taint,
> struct pt_regs *regs, struct warn_args *args);
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
WARNING: multiple messages have this Message-ID (diff)
From: Michal Nazarewicz <mina86@mina86.com>
To: Ian Abbott <abbotti@mev.co.uk>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Borislav Petkov <bp@suse.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Johannes Berg <johannes.berg@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH v4 1/2] asm-generic/bug.h: declare struct pt_regs; before function prototype
Date: Tue, 23 May 2017 20:44:43 +0200 [thread overview]
Message-ID: <xa1twp972z1g.fsf@mina86.com> (raw)
Message-ID: <20170523184443.zAIuhRB63OWfCXmWuiHRZ4J87OFS911Hq7075N1xE4I@z> (raw)
In-Reply-To: <20170523160112.3446-2-abbotti@mev.co.uk>
On Tue, May 23 2017, Ian Abbott wrote:
> The declaration of `__warn()` has `struct pt_regs *regs` as one of its
> parameters. This can result in compiler warnings if `struct regs` is
> not already declared. Add an empty declaration of `struct pt_regs` to
> avoid the warnings.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> v3: Actually, there was no v1 or v2. I called this v3 to match the
> series.
> v4: Corrected 'Acked-by:' line in patch description.
> ---
> include/asm-generic/bug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> index d6f4aed479a1..87191357d303 100644
> --- a/include/asm-generic/bug.h
> +++ b/include/asm-generic/bug.h
> @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const int line);
>
> /* used internally by panic.c */
> struct warn_args;
> +struct pt_regs;
>
> void __warn(const char *file, int line, void *caller, unsigned taint,
> struct pt_regs *regs, struct warn_args *args);
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
WARNING: multiple messages have this Message-ID (diff)
From: Michal Nazarewicz <mina86@mina86.com>
To: Ian Abbott <abbotti@mev.co.uk>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Borislav Petkov <bp@suse.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Johannes Berg <johannes.berg@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Potapenko <glider@google.com>,
Ian Abbott <abbotti@mev.co.uk>
Subject: Re: [PATCH v4 1/2] asm-generic/bug.h: declare struct pt_regs; before function prototype
Date: Tue, 23 May 2017 20:44:43 +0200 [thread overview]
Message-ID: <xa1twp972z1g.fsf@mina86.com> (raw)
In-Reply-To: <20170523160112.3446-2-abbotti@mev.co.uk>
On Tue, May 23 2017, Ian Abbott wrote:
> The declaration of `__warn()` has `struct pt_regs *regs` as one of its
> parameters. This can result in compiler warnings if `struct regs` is
> not already declared. Add an empty declaration of `struct pt_regs` to
> avoid the warnings.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> v3: Actually, there was no v1 or v2. I called this v3 to match the
> series.
> v4: Corrected 'Acked-by:' line in patch description.
> ---
> include/asm-generic/bug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> index d6f4aed479a1..87191357d303 100644
> --- a/include/asm-generic/bug.h
> +++ b/include/asm-generic/bug.h
> @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const int line);
>
> /* used internally by panic.c */
> struct warn_args;
> +struct pt_regs;
>
> void __warn(const char *file, int line, void *caller, unsigned taint,
> struct pt_regs *regs, struct warn_args *args);
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
next prev parent reply other threads:[~2017-05-23 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 16:01 [PATCH v4 0/2] kernel.h: container_of() pointer checking Ian Abbott
2017-05-23 16:01 ` [PATCH v4 1/2] asm-generic/bug.h: declare struct pt_regs; before function prototype Ian Abbott
2017-05-23 18:44 ` Michal Nazarewicz [this message]
2017-05-23 18:44 ` Michal Nazarewicz
2017-05-23 18:44 ` Michal Nazarewicz
2017-05-23 16:01 ` [PATCH v4 2/2] kernel.h: handle pointers to arrays better in container_of() Ian Abbott
2017-05-23 18:44 ` Michal Nazarewicz
2017-05-23 18:44 ` Michal Nazarewicz
2017-05-23 18:44 ` Michal Nazarewicz
2017-05-24 0:54 ` kbuild test robot
2017-05-24 0:54 ` kbuild test robot
2017-05-24 0:54 ` kbuild test robot
2017-05-24 10:46 ` Ian Abbott
2017-05-24 18:59 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1twp972z1g.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=abbotti@mev.co.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=glider@google.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=johannes.berg@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.