From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Subject: Re: [PATCH v4 1/2] asm-generic/bug.h: declare struct pt_regs; before function prototype Date: Tue, 23 May 2017 20:44:43 +0200 Message-ID: References: <20170523160112.3446-1-abbotti@mev.co.uk> <20170523160112.3446-2-abbotti@mev.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:37006 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933479AbdEWSor (ORCPT ); Tue, 23 May 2017 14:44:47 -0400 Received: by mail-wm0-f47.google.com with SMTP id d127so37908606wmf.0 for ; Tue, 23 May 2017 11:44:46 -0700 (PDT) In-Reply-To: <20170523160112.3446-2-abbotti@mev.co.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Cc: Arnd Bergmann , Andrew Morton , Hidehiro Kawai , Borislav Petkov , Rasmus Villemoes , Johannes Berg , Peter Zijlstra , Alexander Potapenko , Ian Abbott On Tue, May 23 2017, Ian Abbott wrote: > The declaration of `__warn()` has `struct pt_regs *regs` as one of its > parameters. This can result in compiler warnings if `struct regs` is > not already declared. Add an empty declaration of `struct pt_regs` to > avoid the warnings. > > Signed-off-by: Ian Abbott > Cc: Arnd Bergmann > Acked-by: Arnd Bergmann Acked-by: Michal Nazarewicz > --- > v3: Actually, there was no v1 or v2. I called this v3 to match the > series. > v4: Corrected 'Acked-by:' line in patch description. > --- > include/asm-generic/bug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > index d6f4aed479a1..87191357d303 100644 > --- a/include/asm-generic/bug.h > +++ b/include/asm-generic/bug.h > @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const = int line); >=20=20 > /* used internally by panic.c */ > struct warn_args; > +struct pt_regs; >=20=20 > void __warn(const char *file, int line, void *caller, unsigned taint, > struct pt_regs *regs, struct warn_args *args); --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:37006 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933479AbdEWSor (ORCPT ); Tue, 23 May 2017 14:44:47 -0400 Received: by mail-wm0-f47.google.com with SMTP id d127so37908606wmf.0 for ; Tue, 23 May 2017 11:44:46 -0700 (PDT) From: Michal Nazarewicz Subject: Re: [PATCH v4 1/2] asm-generic/bug.h: declare struct pt_regs; before function prototype In-Reply-To: <20170523160112.3446-2-abbotti@mev.co.uk> References: <20170523160112.3446-1-abbotti@mev.co.uk> <20170523160112.3446-2-abbotti@mev.co.uk> Date: Tue, 23 May 2017 20:44:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ian Abbott , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Cc: Arnd Bergmann , Andrew Morton , Hidehiro Kawai , Borislav Petkov , Rasmus Villemoes , Johannes Berg , Peter Zijlstra , Alexander Potapenko Message-ID: <20170523184443.zAIuhRB63OWfCXmWuiHRZ4J87OFS911Hq7075N1xE4I@z> On Tue, May 23 2017, Ian Abbott wrote: > The declaration of `__warn()` has `struct pt_regs *regs` as one of its > parameters. This can result in compiler warnings if `struct regs` is > not already declared. Add an empty declaration of `struct pt_regs` to > avoid the warnings. > > Signed-off-by: Ian Abbott > Cc: Arnd Bergmann > Acked-by: Arnd Bergmann Acked-by: Michal Nazarewicz > --- > v3: Actually, there was no v1 or v2. I called this v3 to match the > series. > v4: Corrected 'Acked-by:' line in patch description. > --- > include/asm-generic/bug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > index d6f4aed479a1..87191357d303 100644 > --- a/include/asm-generic/bug.h > +++ b/include/asm-generic/bug.h > @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const = int line); >=20=20 > /* used internally by panic.c */ > struct warn_args; > +struct pt_regs; >=20=20 > void __warn(const char *file, int line, void *caller, unsigned taint, > struct pt_regs *regs, struct warn_args *args); --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934713AbdEWSov (ORCPT ); Tue, 23 May 2017 14:44:51 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38902 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934085AbdEWSor (ORCPT ); Tue, 23 May 2017 14:44:47 -0400 From: Michal Nazarewicz To: Ian Abbott , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Cc: Arnd Bergmann , Andrew Morton , Hidehiro Kawai , Borislav Petkov , Rasmus Villemoes , Johannes Berg , Peter Zijlstra , Alexander Potapenko , Ian Abbott Subject: Re: [PATCH v4 1/2] asm-generic/bug.h: declare struct pt_regs; before function prototype In-Reply-To: <20170523160112.3446-2-abbotti@mev.co.uk> Organization: http://mina86.com/ References: <20170523160112.3446-1-abbotti@mev.co.uk> <20170523160112.3446-2-abbotti@mev.co.uk> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& OpenPGP: id=AC1F5F5CD41888F8CC8458582060401250751FF4; url=http://mina86.com/mina86.pub X-Hashcash: 1:20:170523:abbotti@mev.co.uk::rcwFhVkHq52LW57e:0000000000000000000000000000000000000000000002tf X-Hashcash: 1:20:170523:bp@suse.de::FnlaREjQR6MJXjiq:00000000YlG X-Hashcash: 1:20:170523:akpm@linux-foundation.org::Wjp78BZBFnUgsSbx:0000000000000000000000000000000000000C+f X-Hashcash: 1:20:170523:peterz@infradead.org::oBLkHqBBeMEVe0es:0000000000000000000000000000000000000000024Hy X-Hashcash: 1:20:170523:linux-arch@vger.kernel.org::ridncP4SyORFjr1a:000000000000000000000000000000000002dHm X-Hashcash: 1:20:170523:linux-kernel@vger.kernel.org::GWJv9d3NdZQzlIfI:0000000000000000000000000000000003dNt X-Hashcash: 1:20:170523:abbotti@mev.co.uk::kCIrR+vClQzG6zxm:000000000000000000000000000000000000000000003s7U X-Hashcash: 1:20:170523:johannes.berg@intel.com::QbN5k8GvzkWxtelK:000000000000000000000000000000000000003JUJ X-Hashcash: 1:20:170523:hidehiro.kawai.ez@hitachi.com::saAKMaHyf2G3VzO7:000000000000000000000000000000005SgW X-Hashcash: 1:20:170523:linux@rasmusvillemoes.dk::27NOygGQTpwpUPl6:00000000000000000000000000000000000007ln0 X-Hashcash: 1:20:170523:arnd@arndb.de::1u2gRJoP3kKTP8mW:00008GhL X-Hashcash: 1:20:170523:glider@google.com::7plHBQMFRrwSi8qk:000000000000000000000000000000000000000000008Maq Date: Tue, 23 May 2017 20:44:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4NIissv021308 On Tue, May 23 2017, Ian Abbott wrote: > The declaration of `__warn()` has `struct pt_regs *regs` as one of its > parameters. This can result in compiler warnings if `struct regs` is > not already declared. Add an empty declaration of `struct pt_regs` to > avoid the warnings. > > Signed-off-by: Ian Abbott > Cc: Arnd Bergmann > Acked-by: Arnd Bergmann Acked-by: Michal Nazarewicz > --- > v3: Actually, there was no v1 or v2. I called this v3 to match the > series. > v4: Corrected 'Acked-by:' line in patch description. > --- > include/asm-generic/bug.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h > index d6f4aed479a1..87191357d303 100644 > --- a/include/asm-generic/bug.h > +++ b/include/asm-generic/bug.h > @@ -97,6 +97,7 @@ extern void warn_slowpath_null(const char *file, const int line); > > /* used internally by panic.c */ > struct warn_args; > +struct pt_regs; > > void __warn(const char *file, int line, void *caller, unsigned taint, > struct pt_regs *regs, struct warn_args *args); -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»