From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Guillaume La Roque <glaroque@baylibre.com>
Cc: Igor Opaniuk <igor.opaniuk@gmail.com>,
u-boot@lists.u-boot-project.org,
Jan Kehren <jan.kehren@emteria.com>,
Guillaume La Roque <glaroque@baylibre.com>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 05/10] test/py: android: Add create_gpt_image() for image creation
Date: Tue, 20 Oct 2026 10:41:57 +0200 [thread overview]
Message-ID: <xhkdbmrs84vca.fsf@mkorpers-koolstof.csb> (raw)
In-Reply-To: <179240024783.806974.10399277066432874535.b4-review@b4>
Hi Guillaume,
On Mon, Oct 19, 2026 at 10:57, Guillaume La Roque <glaroque@baylibre.com> wrote:
> On Thu, 15 Oct 2026 15:54:55 +0200, Mattijs Korpershoek <mkorpershoek@kernel.org> wrote:
>
> Hi,
>
> it should probably squash with previous patch it could be more simple to
> review and understand why you do patch 4.
Yes, I initially considered squashing PATCH 04 and PATCH 05 but I found
the diff to be a bit more difficult to review.
I did tell in PATCH 04 that another refactoring was coming:
"""
To prepare a cleaner refactoring, move the image descriptions into an
array and create each partition using a loop.
"""
Should I reword it to make it more clear?
>
> Regards,
> Guillaume
>
> --
> Guillaume La Roque <glaroque@baylibre.com>
next prev parent reply other threads:[~2026-10-20 8:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 13:54 [PATCH 00/10] Fix AVB pytest suite for sandbox Mattijs Korpershoek
2026-10-15 13:54 ` [PATCH 01/10] avb: Use map_to_sysmem() for flush_cache() address Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:26 ` Igor Opaniuk
2026-10-15 13:54 ` [PATCH 02/10] test/py: android: Move android image creation to a dedicated file Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:27 ` Igor Opaniuk
2026-10-15 13:54 ` [PATCH 03/10] test/py: android: Drop verbose printing and unused return Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:27 ` Igor Opaniuk
2026-10-15 13:54 ` [PATCH 04/10] test/py: android: Use for loop to create the images / update disks Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:27 ` Igor Opaniuk
2026-10-15 13:54 ` [PATCH 05/10] test/py: android: Add create_gpt_image() for image creation Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-20 8:41 ` Mattijs Korpershoek [this message]
2026-10-19 10:27 ` Igor Opaniuk
2026-10-15 13:54 ` [PATCH 06/10] test/py: android: Add setup_android_v{4,2}_image subfunctions Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:28 ` [PATCH 06/10] test/py: android: Add setup_android_v{4, 2}_image subfunctions Igor Opaniuk
2026-10-15 13:54 ` [PATCH 07/10] test/py: avb: Use format specifiers instead of str() for mmc_dev Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:28 ` Igor Opaniuk
2026-10-15 13:54 ` [PATCH 08/10] test/py: avb: Move mmc device number to a pytest fixture Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:28 ` Igor Opaniuk
2026-10-15 13:54 ` [PATCH 09/10] test/py: avb: Add sandbox AVB testing with dedicated mmc12 device Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-19 10:26 ` Igor Opaniuk
2026-10-20 8:52 ` Mattijs Korpershoek
2026-10-15 13:55 ` [PATCH 10/10] test/py: avb: Fix find() logic when matching response strings Mattijs Korpershoek
2026-10-19 8:57 ` Guillaume La Roque
2026-10-20 8:31 ` Mattijs Korpershoek
2026-10-19 8:57 ` [PATCH 00/10] Fix AVB pytest suite for sandbox Guillaume La Roque
2026-10-19 9:44 ` Igor Opaniuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xhkdbmrs84vca.fsf@mkorpers-koolstof.csb \
--to=mkorpershoek@kernel.org \
--cc=glaroque@baylibre.com \
--cc=igor.opaniuk@gmail.com \
--cc=jan.kehren@emteria.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.