From: bsegall@google.com
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Yuyang Du <yuyang.du@intel.com>,
Morten Rasmussen <Morten.Rasmussen@arm.com>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Paul Turner <pjt@google.com>
Subject: Re: [PATCH 7/7 v3] sched: fix wrong utilization accounting when switching to fair class
Date: Thu, 22 Sep 2016 10:10:18 -0700 [thread overview]
Message-ID: <xm261t0beu85.fsf@bsegall-linux.mtv.corp.google.com> (raw)
In-Reply-To: <20160922083351.GV5012@twins.programming.kicks-ass.net> (Peter Zijlstra's message of "Thu, 22 Sep 2016 10:33:51 +0200")
Peter Zijlstra <peterz@infradead.org> writes:
> On Tue, Sep 20, 2016 at 09:59:08AM -0700, bsegall@google.com wrote:
>> Peter Zijlstra <peterz@infradead.org> writes:
>> > Google has this patch-set replacing min_vruntime with an actual global
>> > 0-lag, which greatly simplifies things. If only they'd post it sometime
>> > :/ /me prods pjt and ben with a sharp stick :-)
>> >
>>
>> No, we don't have any patches like that. I wish, we've screwed up
>> vruntime a couple of times too.
>
> Hurm, I was sure you guys were doing something entirely different from
> what mainline does.
>
> IIRC Andrew Hunter was 'working' on getting that posted. See also:
> lkml.kernel.org/r/CADroS=6Ncpao6WWXBxboB6quqUP96EnjbsDUZqNgASd_PzDGaA@mail.gmail.com
Oh, I was looking at the wrong branches. Sigh.
Yeah, we just do an unlocked "se->vruntime -= old->min_vruntime -
new->min_vruntime;" in migrate, and remove/add it in
switched_from/switched_to_fair.
This still isn't replacing min_vruntime with anything cool, perhaps you
and Andrew were using opposite definitions of relative here - we have
fair tasks always having a vruntime that is relative to min_vruntime,
rather than temporarily having the 0-based one when doing
non-SLEEP/WAKEUP.
next prev parent reply other threads:[~2016-09-22 17:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 7:47 [PATCH 0/7 v3] sched: reflect sched_entity move into task_group's load Vincent Guittot
2016-09-12 7:47 ` [PATCH 1/7 v3] sched: factorize attach entity Vincent Guittot
2016-09-12 7:47 ` [PATCH 2/7 v3] sched: fix hierarchical order in rq->leaf_cfs_rq_list Vincent Guittot
2016-09-21 10:14 ` Dietmar Eggemann
2016-09-21 12:34 ` Vincent Guittot
2016-09-21 17:25 ` Dietmar Eggemann
2016-09-21 18:02 ` Vincent Guittot
2016-09-12 7:47 ` [PATCH 3/7 v3] sched: factorize PELT update Vincent Guittot
2016-09-15 13:09 ` Peter Zijlstra
2016-09-15 13:30 ` Vincent Guittot
2016-09-12 7:47 ` [PATCH 4/7 v3] sched: propagate load during synchronous attach/detach Vincent Guittot
2016-09-15 12:55 ` Peter Zijlstra
2016-09-15 13:01 ` Vincent Guittot
2016-09-15 12:59 ` Peter Zijlstra
2016-09-15 13:11 ` Vincent Guittot
2016-09-15 13:11 ` Dietmar Eggemann
2016-09-15 14:31 ` Vincent Guittot
2016-09-15 17:20 ` Dietmar Eggemann
2016-09-15 15:14 ` Peter Zijlstra
2016-09-15 17:36 ` Dietmar Eggemann
2016-09-15 17:54 ` Peter Zijlstra
2016-09-15 14:43 ` Peter Zijlstra
2016-09-15 14:51 ` Vincent Guittot
2016-09-19 3:19 ` Wanpeng Li
2016-09-12 7:47 ` [PATCH 5/7 v3] sched: propagate asynchrous detach Vincent Guittot
2016-09-12 7:47 ` [PATCH 6/7 v3] sched: fix task group initialization Vincent Guittot
2016-09-12 7:47 ` [PATCH 7/7 v3] sched: fix wrong utilization accounting when switching to fair class Vincent Guittot
2016-09-15 13:18 ` Peter Zijlstra
2016-09-15 15:36 ` Vincent Guittot
2016-09-16 12:16 ` Peter Zijlstra
2016-09-16 14:23 ` Vincent Guittot
2016-09-20 11:54 ` Peter Zijlstra
2016-09-20 13:06 ` Vincent Guittot
2016-09-22 12:25 ` Peter Zijlstra
2016-09-26 14:53 ` Peter Zijlstra
2016-09-20 16:59 ` bsegall
2016-09-22 8:33 ` Peter Zijlstra
2016-09-22 17:10 ` bsegall [this message]
2016-09-16 10:51 ` Peter Zijlstra
2016-09-16 12:45 ` Vincent Guittot
2016-09-30 12:01 ` [tip:sched/core] sched/core: Fix incorrect " tip-bot for Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xm261t0beu85.fsf@bsegall-linux.mtv.corp.google.com \
--to=bsegall@google.com \
--cc=Morten.Rasmussen@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.