From: Benjamin Segall <bsegall@google.com>
To: zenghongling <zenghongling@kylinos.cn>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de,
vschneid@redhat.com, linux-kernel@vger.kernel.org,
zhongling0719@126.com
Subject: Re: [PATCH v1] sched: adjust the layout of the cfs_bandwith structure to save memory
Date: Wed, 21 Jan 2026 13:15:12 -0800 [thread overview]
Message-ID: <xm267btamzvj.fsf@google.com> (raw)
In-Reply-To: <20260119032903.11754-1-zenghongling@kylinos.cn> (zenghongling@kylinos.cn's message of "Mon, 19 Jan 2026 11:29:03 +0800")
zenghongling <zenghongling@kylinos.cn> writes:
> Using pahole, we can see that there are some padding holes
> in the current cfs_bandwith structure. Adjusting the
> layout of cfs_bandwith can reduce these holes,
> resulting in the size of the structure decreasing
> from 240 bytes to 232 bytes.
> It is possible to make period_timer access one more cache
> line.it is already touching so many cachelines and isn't
> that kind of hot path.
Something more like: "This make make period_timer access one more cache
line, but it is already [...]"
And commits generally have a blank line between paragraphs.
With that,
Reviewed-by: Ben Segall <bsegall@google.com>
prev parent reply other threads:[~2026-01-21 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 3:29 [PATCH v1] sched: adjust the layout of the cfs_bandwith structure to save memory zenghongling
2026-01-21 21:15 ` Benjamin Segall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xm267btamzvj.fsf@google.com \
--to=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vschneid@redhat.com \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.