From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED678359A68 for ; Thu, 28 May 2026 22:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780005828; cv=none; b=WugSPgqreyA86ig2Z8oNxqGyNod/IVEIV9kzJ1rMCc9W19aLrZsRMsPYLhVFp2xj2nt6IhbjCvwKI+GfTmEG+KL879H6AJLsRuMFluM7kjfXEoXGhcrFVnCWjcw6yEPqs8mOZR4SqUZw23JKhzbrNlV7eDws1mmxWg5P2HBAU5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780005828; c=relaxed/simple; bh=f/aj5o53jeJfBjmEfWOlyP3qBA1owVUrrOpRnQ4j/yg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Agkf64puJzIDNA1IrDVD/WAF3ne/hUOdRpFTj8updLUXHFtxvfGl3b2n8TCz6imgV7Lkwn7Uw0OywLD0eaNcqlECpvsVTqv2grfoMZfZhPC6wI0YFYuFfR7KcaHrWLgJSOLd45JW9wlDisHaihNp1HCOouk2rX0xg2ppZtVBDDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vlS06f6U; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vlS06f6U" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-132830d8281so485570c88.1 for ; Thu, 28 May 2026 15:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780005826; x=1780610626; darn=vger.kernel.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=f/aj5o53jeJfBjmEfWOlyP3qBA1owVUrrOpRnQ4j/yg=; b=vlS06f6U7BAf8TWAxplxKpLVPD7MRlQd5OsIGtSrU2G7mYh0O8hoWICLtdCb7UrzjC SHA0Ey5lUFwfIK6KuucfcJh6xUMcMemSaT+YhgXrKvA81peklOPCVSzJm5qlcZyDFVE0 Ta2dQk+j+ilsRb+GG3RMYmiSbiiCh6bKjB+5vHu5IqxZcYzo2K5Vi6K8uJ2YlxX+H9g8 d1W+dTu8/QklUqEf3NefDzFsDgIzuDf6ZvMEkoFJHVEFsSYXkcqDu/JdsqCOFjaYBv7g JGPjggw7NWSfpz+N2U/kkg9jl4DfY0GfPc/OjIL5howMp9h0VzoP3cnDXyrppLjKqiUy i6+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780005826; x=1780610626; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=f/aj5o53jeJfBjmEfWOlyP3qBA1owVUrrOpRnQ4j/yg=; b=fhxIwyD1B9p0gzNbgaob/tTOE1ujarakTzg5e3tWNQIrXSNdkYtRc2bYwjRTpSaj09 8P96gLRCqYjqWZgXKe/PgiN5CrG0+UZPXTvE0ePoViNPH2i+3VpWX3dzH6+/oP9gvGNp zU1d+OprFszdP/kqCUxsGqjAgho9L8+TaJIA/t5TPdre4NhdTK2cILQJ0wyjomW53XFS WIOnkkHKCqkDTvZPmUegwBUNMvLWTGZ/8wRNsLqqsdLcKz+3tI8f2uAexaA1k2IEWRjV VkyVFqYpGPyKu69Kl9jU2M/8TtsAMfdehWc9SrdtIsKwd0WdQQ2T0aFlseXCarrm1Imo Ip1g== X-Forwarded-Encrypted: i=1; AFNElJ/hDVQdj28TZ8WTqrNXOQR4JAJOm9ziZDJ8Hq1PA9zQ//hZRCVWZJcXFmMrk79dALoC79LyQS2ZlsqM5v0=@vger.kernel.org X-Gm-Message-State: AOJu0YxzabwOW9CVUeGvbWoHVFz+4U+c39J756wC6MUaYuyG2f0BpeYs nDxD7LliR5mVVsyXKacfZDgiMDJuyzBURJDrj5KcY6H7+fUwJ881j9pKGVCw8sMQO62tgQ29Qnl 9ZGvL5QnXOgE= X-Gm-Gg: Acq92OGWsV8r7zCWxPYI0k4uVA/Py7PEy9am3qlFHgPHQngUM6YPvW2nDV7mXqo1dFX W/oMq0Ta1vj2ObGGb2p5Om5UbPlZhN7h+wvo/+ls7K86cpPGtTWlyyNkg6Rq7EZJoKls/sgfAo8 MQTdHxVHMgePfyhfmBopO377b1VgOpcpoZ/mREo2GaSva4YoiEJYY8jgH64dISu74CTbY0L4+9u 4QzdZMOQZFfkloFiNVfkyhCPZa8lOqtsLcLz/kxmB4k1mHXhJ4B8NO8ULH1ax2uS5XS4aAh8+32 enNyKFtBXI1GJ4c4P4PqooBK8S4AzmRKl7m2aimhDKqf7eBXU+fLqH6fRusIBMe+KsHS4rvBzN4 6F94JsH06CbpzDgEWLq35mHMyu6rOVrht+O5gIXHOFXPccv+l7LG7qQuevsWcvA01Ak5c1Nkzv/ IU6nPwBFqjC108TyjdbhSLxWU4SGFt4zR+nPFA/Hqht97GQ1BCzCdu X-Received: by 2002:a05:7022:217:b0:136:72f0:6c54 with SMTP id a92af1059eb24-137aeef207emr93959c88.29.1780005825357; Thu, 28 May 2026 15:03:45 -0700 (PDT) Received: from bsegall27.localhost ([98.45.141.147]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-137b03fd4c8sm90053c88.1.2026.05.28.15.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 15:03:44 -0700 (PDT) From: Benjamin Segall To: K Prateek Nayak Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Mel Gorman , Valentin Schneider , Aaron Lu , Josh Don , Subject: Re: [PATCH 3/5] sched/fair: Call update_curr() before unthrottling the hierarchy In-Reply-To: <20260528094830.13291-4-kprateek.nayak@amd.com> (K. Prateek Nayak's message of "Thu, 28 May 2026 09:48:28 +0000") References: <20260528094830.13291-1-kprateek.nayak@amd.com> <20260528094830.13291-4-kprateek.nayak@amd.com> Date: Thu, 28 May 2026 15:03:42 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain K Prateek Nayak writes: > Subsequent commits will allow update_curr() to throttle the hierarchy > when the runtime accounting exceeds allocated quota. Call update_curr() > before the unthrottle event, and in tg_unthrottle_up() to catch up on > any remaining runtime and stabilize the "runtime_remaining" and > "throttle_count" for that cfs_rq. > > Doing an update_curr() early ensures the cfs_rq is not throttled right > back up again when the unthrottle is in progress. > > Since all callers of unthrottle_cfs_rq(), except one, already update the > rq_clock and call rq_clock_start_loop_update(), move the > update_rq_clock() in unthrottle_cfs_rq() to the lonely caller that > doesn't update the rq_clock. Reviewed-By: Benjamin Segall