From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 121CB44AB75 for ; Tue, 21 Jul 2026 21:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784667766; cv=none; b=op0UEIeJ7kc8gUTMQXJjzUG+20sskl6AZpOA/84CY1zL/f5G6qpvfGOTsCSz33/5cjQonvmZM7nWD//dxp71+NAzMvxO5oSwR2H+CzF52efzjLFuRQU5s69gsqfVol6LaeXi8HS/Uqay4Yii/qPkv587jeEzNxcSjuq5zAYE1mM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784667766; c=relaxed/simple; bh=0dGBrb6k61X8cUt2Emr0Xqy9vDpvUaU9B4KHysMTNc4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ner0FzXsWRPbqgqNZ9Rr92CP+UUp2efEauvqjfQZcyQO8SZqG3zKReRNyUnFGAYCRqkoArJ4bZy8cIQO22wj82nbOAq8YhCP+FZCwz3vlclYs52mX2KgQU/+KesYD160u5PCFl7A3jipyFrJP0h9T1cYlLP+VuKxWQJCc9Vd6Es= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uYqvGy6i; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uYqvGy6i" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so6284241a91.3 for ; Tue, 21 Jul 2026 14:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784667758; x=1785272558; darn=vger.kernel.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=zUtoAa7HhyZ6QbnRbGkdSAGOo6aNwCKk+ukGGnDMKk0=; b=uYqvGy6i2rkUISTB2pTD93dwXdTcZAjbmxq7Dt+VXR4E0be0Y9hP3ydWQ7bI0ujrfC y+YCChf8Sqjp4OUv2CsacpgdAgOAFEO5fyTnjBMfIoApykVAIX67ayeq2smhwVNWwIVR 6Z8zTruIvrc2+esAnTXoDAoMtsZ1OvVq6vxSjkc1UNhloo3bGMyv4KU+gspT8foHIo2u xdTQHVS5bk4qAUL8QWqwOPb/k1bmn37Y8h24dc1wLSFVvLdyE8lyRFhxMRNPrfRv/oZy v/nEiJQeUFYtlO8b4SBJOLkuHXUvnDcAmTMHkeL2zD7nlfFnjupHjmVwzb3Tj3PcP5Yu yXCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784667758; x=1785272558; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=zUtoAa7HhyZ6QbnRbGkdSAGOo6aNwCKk+ukGGnDMKk0=; b=AU9stvX+qk8hvI9LdXhWBOnH4MuAeevL8GprxHZbFHcO1BoS5j2QHssLHiwccKNtb9 d7xDF9JSP+gVXRd0LIbVb47knezQ8elMg1cr8F60QTq6IFI/8VAYWvxsgtHKPB/5+92P i4wQ1ZwROsARumBGE6b6gdIVa3ChmqGoClgOiNupUZAbz3q3DbOyRRWPNxT9UO9gTRZv LRHFy586hBD4mMylrPONRE6YnAeFXCJAmElOq3vY+YFUpRwV6n12nIseh4CjEVGyBgiE GPesxMsrWiK+0Qo+0PM42OSEaSqIeF+ry1zmy3KJ3uwrqUXXdsGub6KeDrhkkoHaBG8t GsyQ== X-Forwarded-Encrypted: i=1; AHgh+RqtilOqiE5A9d1zl/z0SRFRGHTHHmFNl94TgUiR/vZfPlh9uV/UEXxfyoMeU9zBrv1BfySuFitjpoxTdMY=@vger.kernel.org X-Gm-Message-State: AOJu0YwHce8q0lUFy+KidM45L0MImCMa2dgkV4qERSR+Y/lKoDWUMLdq LETL3AZny195pTwPMLiiTLfXuAgqr6YZbJzKy/OWLdUo+yoy5Fqi5XL6c6eycNbpunKr09Zx+I+ L1KfAQqKq X-Gm-Gg: AR+sD118iWdnb30pMosLwYfWSaRgUualrqczscu6GQjXVhLcYoy9QEF30Ly5F3yHyKG Rev/Xk6xDVV10K2Z3aoEmjjnXTFfBqKADPX1rr8OFQi8HVa5fF66xq3UafazBlGbS8YFRK+cDz6 J6TzWiNL1lWaoAhz/isXON+J7mG09v/RDF0gbNrpScevrynmq3G62b8SzPmtNawMJagzW1Ym0oX X0SeZyZweGU0H6frh82c85I7mofzROfaWothTlE0Gc6QP3MAflUNehrpKteiM+dC2v5aryGy6Sp QBofgJM10DnxIQzThXLbmX1iXtyp9CWkeUG5kEDEUvWogiLH6QVlnyalvbZYMrciStPji0Y/cKq nYNF2/oIoSfvHx4+rfN2/Nw7KiD7GLGIVvF/QmWGEnVjGoh4eQm8PKzlJy0SI3yOCf8KgltRuLj PV8UApp8BmH6CCk1e+ZXC9x+LRGBA0rhHs30iwBvluwLKd X-Received: by 2002:a17:90a:f948:b0:38e:69b5:538f with SMTP id 98e67ed59e1d1-38e69b554a7mr10478408a91.28.1784667757525; Tue, 21 Jul 2026 14:02:37 -0700 (PDT) Received: from bsegall27.localhost ([2a00:79e0:2ed2:d:2805:76f:a037:b7ac]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce2ddfb35sm46446277c88.14.2026.07.21.14.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 14:02:37 -0700 (PDT) From: Benjamin Segall To: Hongyan Xia Cc: "mingo@redhat.com" , "peterz@infradead.org" , "juri.lelli@redhat.com" , "vincent.guittot@linaro.org" , "dietmar.eggemann@arm.com" , "rostedt@goodmis.org" , "mgorman@suse.de" , "vschneid@redhat.com" , "kprateek.nayak@amd.com" , Jiazi Li , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] sched/fair: Move __cfs_bandwidth_used to new static key API In-Reply-To: (Hongyan Xia's message of "Mon, 20 Jul 2026 09:38:04 +0000") References: Date: Tue, 21 Jul 2026 14:02:33 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hongyan Xia writes: > From: Hongyan Xia > > Using struct static_key directly is deprecated. Fix. > > No functional change. > > Signed-off-by: Hongyan Xia Reviewed-By: Ben Segall > --- > kernel/sched/fair.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 422284fb815f..e03c2610d2c3 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -6442,21 +6442,21 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued) > #ifdef CONFIG_CFS_BANDWIDTH > > #ifdef CONFIG_JUMP_LABEL > -static struct static_key __cfs_bandwidth_used; > +static DEFINE_STATIC_KEY_FALSE(__cfs_bandwidth_used); > > static inline bool cfs_bandwidth_used(void) > { > - return static_key_false(&__cfs_bandwidth_used); > + return static_branch_unlikely(&__cfs_bandwidth_used); > } > > void cfs_bandwidth_usage_inc(void) > { > - static_key_slow_inc_cpuslocked(&__cfs_bandwidth_used); > + static_branch_inc_cpuslocked(&__cfs_bandwidth_used); > } > > void cfs_bandwidth_usage_dec(void) > { > - static_key_slow_dec_cpuslocked(&__cfs_bandwidth_used); > + static_branch_dec_cpuslocked(&__cfs_bandwidth_used); > } > #else /* !CONFIG_JUMP_LABEL: */ > static bool cfs_bandwidth_used(void)