Re: [RFC PATCH 4/6] hex: label usages of hex parsing for object IDs

[Junio C Hamano <gitster@pobox.com>]

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> In preparation for a future change, label the hex parsing we're doing
> for object IDs by defining a constant called HEX_KIND_OID.  This is
> currently the same as HEX_KIND_MIXED, so there is no functional change
> here.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>  diagnose.c    | 2 +-
>  hex-ll.h      | 2 ++
>  hex.c         | 2 +-
>  http-push.c   | 4 ++--
>  notes.c       | 2 +-
>  object-file.c | 2 +-
>  6 files changed, 8 insertions(+), 6 deletions(-)

OK.  It makes sense to say "we are reading object names", than "we
are reading hex spelled in both cases".  Are we throwing the "not
object names but derived from the same hash function" things like
packname and rerere database key into the same category?

> diff --git a/diagnose.c b/diagnose.c
> index fc11cea229..9c652d36a6 100644
> --- a/diagnose.c
> +++ b/diagnose.c
> @@ -112,7 +112,7 @@ static void loose_objs_stats(struct strbuf *buf, const char *path)
>  	while ((e = readdir_skip_dot_and_dotdot(dir)) != NULL)
>  		if (get_dtype(e, &count_path, 0) == DT_DIR &&
>  		    strlen(e->d_name) == 2 &&
> -		    !hex_to_bytes(&c, e->d_name, 1, HEX_KIND_MIXED)) {
> +		    !hex_to_bytes(&c, e->d_name, 1, HEX_KIND_OID)) {
>  			strbuf_setlen(&count_path, base_path_len);
>  			strbuf_addf(&count_path, "%s/", e->d_name);
>  			total += (count = count_files(&count_path));