All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@collabora.com>
Cc: Jeff King <peff@peff.net>,  git@vger.kernel.org
Subject: Re: [PATCH v4] log: improve --follow following renames for non-linear history
Date: Mon, 22 Jun 2026 05:44:43 -0700	[thread overview]
Message-ID: <xmqq1pdy4udg.fsf@gitster.g> (raw)
In-Reply-To: <ajjU4w2B0NlZffw1@collabora.com> (Miklos Vajna's message of "Mon, 22 Jun 2026 08:23:31 +0200")

Miklos Vajna <vmiklos@collabora.com> writes:

> I noticed that merging 'mv/log-follow-mergy' to 'master' results in a
> (simple) conflict since commit 42d960748e (line-log: integrate -L output
> with the standard log-tree pipeline, 2026-05-28), this is an updated
> version that resolves the conflict.
> ...
> Please replace the content of that branch with this patch.

If there are changes of substance, polishing with new iterations is
welcome even without any code change (e.g., clarifying the proposed
log message or documentation to help future readers understand what
went on in this patch would count), but as long as the resolution
that is in my tree (as a part of 'seen') exactly matches what your
update contains (meaning: rerere will do the same correct resolution
when the topic gets merged to 'master' anyway) and the conflict is
trivial to resolve by hand for others, which seems to be the case
here,

    $ git checkout --detach master
    $ git -c rerere.autoupdate merge mv/log-follow-mergy
    $ git commit --no-edit
    $ HERE=$(git rev-parse HEAD)
    $ git reset --hard HEAD^ ;# back at 'master'
    $ git am $this_message
    $ git diff $HERE ;# shows nothing
    $ git range-diff master..$HERE master..HEAD ;# no change in the log message

I'd prefer not to see such a reroll.

Thanks.

  reply	other threads:[~2026-06-22 12:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  7:21 [PATCH] log: let --follow follow renames in merge commits Miklos Vajna
2026-05-19  6:17 ` Miklos Vajna
2026-05-19  6:37   ` Junio C Hamano
2026-05-19  8:14     ` Junio C Hamano
2026-06-08  6:35       ` [PATCH] log: improve --follow following renames for non-linear history Miklos Vajna
2026-06-08 15:10         ` Junio C Hamano
2026-06-11  6:18           ` [PATCH v2] " Miklos Vajna
2026-06-11 22:32             ` Junio C Hamano
2026-06-15  6:22               ` [PATCH v3] " Miklos Vajna
2026-06-22  6:23                 ` [PATCH v4] " Miklos Vajna
2026-06-22 12:44                   ` Junio C Hamano [this message]
2026-06-12 20:10             ` [PATCH v2] " Junio C Hamano
2026-05-20 13:28     ` [PATCH] log: let --follow follow renames in merge commits Miklos Vajna
2026-05-22  5:43       ` Jeff King
2026-05-23  6:04         ` [PATCH] log: improve --follow following " Miklos Vajna
2026-05-30  6:28           ` Miklos Vajna
2026-06-04 12:20             ` Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1pdy4udg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=vmiklos@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.