All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: kristofferhaugsbakk@fastmail.com,  git@vger.kernel.org,
	 Kristoffer Haugsbakk <code@khaugsbakk.name>,
	 Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] doc: shortlog: put back trailer paragraphs
Date: Mon, 02 Feb 2026 11:03:37 -0800	[thread overview]
Message-ID: <xmqq1pj3ynli.fsf@gitster.g> (raw)
In-Reply-To: <20260202182421.GA3421838@coredump.intra.peff.net> (Jeff King's message of "Mon, 2 Feb 2026 13:24:21 -0500")

Jeff King <peff@peff.net> writes:

> On Mon, Feb 02, 2026 at 06:59:42PM +0100, kristofferhaugsbakk@fastmail.com wrote:
>
>> 47beb37b (shortlog: match commit trailers with --group, 2020-09-27)
>> added the `trailer` bullet point with three paragraphs.[1] Later,
>> 3dc95e09 (shortlog: support arbitrary commit format `--group`s,
>> 2022-10-24) put the single-paragraph bullet point about `format` right
>> after the first paragraph about `trailer`. That meant that the second
>> and third paragraphs for `trailer` got moved to `format`.
>> 
>> Move the two paragraphs back to `trailer`. We now also need one blank
>> line before the final bullet point so that it does not get joined with
>> the second bullet point.
>
> Yeah, the change in 3dc95e09 was obviously wrong. The results look good
> here, via both doc-diff output and just eyeballing the generated .html
> file. Thanks for catching this.

Thanks, both.

  reply	other threads:[~2026-02-02 19:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 17:59 [PATCH] doc: shortlog: put back trailer paragraphs kristofferhaugsbakk
2026-02-02 18:24 ` Jeff King
2026-02-02 19:03   ` Junio C Hamano [this message]
2026-02-03  9:48 ` [PATCH v2] " kristofferhaugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1pj3ynli.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.