All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
	 git@vger.kernel.org, christian.couder@gmail.com,  ps@pks.im,
	 shejialuo@gmail.com, johncai86@gmail.com,
	 Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [RFC PATCH] config: teach `repo_config()` to allow `repo` to be NULL
Date: Mon, 03 Mar 2025 10:24:00 -0800	[thread overview]
Message-ID: <xmqq1pvevupr.fsf@gitster.g> (raw)
In-Reply-To: <CAPSxiM9x=3WTmH-NSuV7Z1FtXMJ6v5B0R-zB3DOKcyiLKXy2rg@mail.gmail.com> (Usman Akinyemi's message of "Mon, 3 Mar 2025 23:07:36 +0530")

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

> On Sun, Mar 2, 2025 at 1:15 AM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
>>
>> > Also, about the testing, I was thinking of using the clar framework or the
>> > test-tool, do you have any in mind ?
>>
>> Neither of them seems a good fit for the task to me.
>>
>> Once you rewrite one of the built-in commands using this and run
>> "git $cmd -h" under "nongit" helper, wouldn't that be a good enough
>> test to future-proof the codepath?
> Thanks for this.
>
> To confirm, You meant using the "nonigt" functions in test files
> inside the "t/" directory?

Sorry, but I do not quite understand the question.

What I meant was to peek at existing practice in

	$ git grep '	nongit ' 't/t[0-9][0-9][0-9][0-9]-*.sh'

for inspirations, like

t/t4203-mailmap.sh:	nongit git shortlog -s <input >actual &&

where a command pretends to be run "outside" a repository.


      reply	other threads:[~2025-03-03 18:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 17:54 [RFC PATCH] config: teach `repo_config()` to allow `repo` to be NULL Usman Akinyemi
2025-02-27 18:35 ` Eric Sunshine
2025-02-27 18:46 ` Junio C Hamano
2025-02-28 10:56 ` Phillip Wood
2025-02-28 18:14   ` Junio C Hamano
2025-02-28 23:56     ` Usman Akinyemi
2025-03-01 19:45       ` Junio C Hamano
2025-03-03 17:37         ` Usman Akinyemi
2025-03-03 18:24           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1pvevupr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=johncai86@gmail.com \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    --cc=shejialuo@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.