From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
git@vger.kernel.org, Aarni Koskela <aarni@valohai.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] object-name: fix reversed ordering with ":/<PATTERN>" revisions
Date: Sat, 07 Dec 2024 07:46:55 +0900 [thread overview]
Message-ID: <xmqq1pykwhsw.fsf@gitster.g> (raw)
In-Reply-To: <Z1McGsD8nG5x43g9@pks.im> (Patrick Steinhardt's message of "Fri, 6 Dec 2024 16:45:30 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> Fair, I should've double checked. Anyway, verifying the behaviour of
> both in the added test is probably still sensible.
I'll queue with this range-diff on top. :/<text> is explained in
"git help revisions" as "reachable from any ref", and it is a good
phrase to use there, I think.
Thanks, both, I should've double-checked, too.
## Commit message ##
object-name: fix reversed ordering with ":/<PATTERN>" revisions
- Recently it was reported [1] that "look for the youngest reachable
- commit with log message that match the given pattern" syntax (e.g.
- ':/<PATTERN>' or 'HEAD^{/<PATTERN>}') started to return results in
+ Recently it was reported [1] that "look for the youngest commit
+ reachable from any ref with log message that match the given
+ pattern" syntax (e.g. ':/<PATTERN>') started to return results in
reverse recency order. This regression was introduced in Git v2.47.0 and
is caused by a memory leak fix done in 57fb139b5e (object-name: fix
leaking commit list items, 2024-08-01).
next prev parent reply other threads:[~2024-12-06 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 9:51 [PATCH] object-name: fix reversed ordering with magic pathspecs Patrick Steinhardt
2024-12-06 11:20 ` Kristoffer Haugsbakk
2024-12-06 11:57 ` Junio C Hamano
2024-12-06 12:05 ` Patrick Steinhardt
2024-12-06 12:25 ` Kristoffer Haugsbakk
2024-12-06 22:40 ` Junio C Hamano
2024-12-06 12:25 ` Patrick Steinhardt
2024-12-06 12:28 ` [PATCH v2] object-name: fix reversed ordering with ":/<PATTERN>" revisions Patrick Steinhardt
2024-12-06 14:33 ` Kristoffer Haugsbakk
2024-12-06 15:45 ` Patrick Steinhardt
2024-12-06 22:46 ` Junio C Hamano [this message]
2024-12-07 2:05 ` Justin Tobler
2024-12-06 15:45 ` [PATCH v3] " Patrick Steinhardt
2024-12-07 15:51 ` Kristoffer Haugsbakk
2024-12-07 23:24 ` Junio C Hamano
2024-12-09 11:47 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pykwhsw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aarni@valohai.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.