From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: ArcticLampyrid <ArcticLampyrid@outlook.com>,
Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org
Subject: Re: SIGSEGV Error Occurs When Attempting to Unbundle Without Initializing Git Repository.
Date: Mon, 12 Aug 2024 08:55:12 -0700 [thread overview]
Message-ID: <xmqq1q2t7n33.fsf@gitster.g> (raw)
In-Reply-To: <20240812114733.GA3732689@coredump.intra.peff.net> (Jeff King's message of "Mon, 12 Aug 2024 07:47:33 -0400")
Jeff King <peff@peff.net> writes:
> - "verify" requires a repo, which I wouldn't have expected, but I
> guess it's because we probably unbundle under the hood to walk.
> Anyway, it gets the ordering right here and checks the repo before
> opening the bundle.
In hindsight "verify" is misnamed and overrated. Its purpose is to
check if the bundle can be unbundled into your _current_ repository
by checking if you have all the commits _required_ to unbundle the
bundle.
In fact, I doubt that "verify" looks at the pack stream part of the
file at all.
> - list-heads doesn't require a repo, and segfaults. So it really does
> need some kind of detection or default to know which hash to use.
Yes.
next prev parent reply other threads:[~2024-08-12 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 10:57 SIGSEGV Error Occurs When Attempting to Unbundle Without Initializing Git Repository ArcticLampyrid
2024-08-12 11:47 ` Jeff King
2024-08-12 15:55 ` Junio C Hamano [this message]
2024-08-12 21:05 ` brian m. carlson
2024-08-13 9:18 ` [PATCH 0/2] bundle: fix handling of object format Patrick Steinhardt
2024-08-13 9:18 ` [PATCH 1/2] builtin/bundle: have unbundle check for repo before opening its bundle Patrick Steinhardt
2024-08-13 9:21 ` Eric Sunshine
2024-08-13 9:18 ` [PATCH 2/2] bundle: default to SHA1 when reading bundle headers Patrick Steinhardt
2024-08-13 11:24 ` Jeff King
2024-08-13 15:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1q2t7n33.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ArcticLampyrid@outlook.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.