All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Daniel Stenberg <daniel@haxx.se>
Cc: git@vger.kernel.org
Subject: Re: FYI: git issues with libcurl 8.0/1 HTTPS push
Date: Tue, 22 Aug 2023 09:59:30 -0700	[thread overview]
Message-ID: <xmqq1qfvm2rx.fsf@gitster.g> (raw)
In-Reply-To: <4q22785-1qr2-824o-806r-26srs4r8p34@unkk.fr> (Daniel Stenberg's message of "Tue, 22 Aug 2023 18:42:55 +0200 (CEST)")

Daniel Stenberg <daniel@haxx.se> writes:

> The downside with this approach is that you make it build-time. Since
> libcurl 8.2.x is binary compatible with the previous versions, users
> could easily upgrade to a newer libcurl without rebuilding git and
> then unnecessarily have the avoid-h2 code still used.
>
> The ideal approach would do the check in run-time to avoid that.

True.  I however suspect that the ship has already sailed for our
use of libcurl with how git-curl-compat.h uses LIBCURL_VERSION_NUM
for other things already.  A binary of Git built with older libcurl
versions would have compiled out certain features and would still
work with newer libcurl.

Thanks.

      reply	other threads:[~2023-08-22 16:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 11:32 FYI: git issues with libcurl 8.0/1 HTTPS push Daniel Stenberg
2023-08-22 16:27 ` Junio C Hamano
2023-08-22 16:42   ` Daniel Stenberg
2023-08-22 16:59     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1qfvm2rx.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=daniel@haxx.se \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.