All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Glen Choo via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Victoria Dye <vdye@github.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Glen Choo <chooglen@google.com>
Subject: Re: [PATCH] setup.c: don't setup in discover_git_directory()
Date: Fri, 16 Jun 2023 09:03:42 -0700	[thread overview]
Message-ID: <xmqq1qibs8bl.fsf@gitster.g> (raw)
In-Reply-To: <9a7602ba-6903-a94a-3bb5-e51c76f08058@gmx.de> (Johannes Schindelin's message of "Fri, 16 Jun 2023 13:50:22 +0200 (CEST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> As explained by 16ac8b8db6 (setup: introduce the
>> discover_git_directory() function, 2017-03-13) and the comment on its
>> declaration, discover_git_directory() is intended to be an entrypoint
>> into setup.c machinery that allows the Git directory to be discovered
>> without side effects, e.g. so that read_early_config() can read
>> ".git/config" before the_repository has been set up.
>>
>> Fortunately, we didn't start to rely on this unintended behavior between
>> then and now, so we let's just remove it. It isn't harming anyone, but
>> it's confusing.
>>
>> Signed-off-by: Glen Choo <chooglen@google.com>
>
> As the author of the commit whose rationale was quoted above, I am
> delighted to provide my ACK to both commit message and diff.
>
> Thanks,
> Johannes

Thanks, both, for writing and reviewing.

Queued.


      reply	other threads:[~2023-06-16 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 19:35 [PATCH] setup.c: don't setup in discover_git_directory() Glen Choo via GitGitGadget
2023-06-16 11:50 ` Johannes Schindelin
2023-06-16 16:03   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1qibs8bl.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chooglen@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jonathantanmy@google.com \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.