All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Kir Kolyshkin <kolyshkin@gmail.com>,
	git@vger.kernel.org, Roman Dodin <dodin.roman@gmail.com>
Subject: Re: [PATCH] remote: align columns on -v
Date: Wed, 08 Feb 2023 08:32:55 -0800	[thread overview]
Message-ID: <xmqq1qn0ungo.fsf@gitster.g> (raw)
In-Reply-To: <20230208161222.guqqwlceqiy3jq7e@tb-raspi4> ("Torsten Bögershausen"'s message of "Wed, 8 Feb 2023 17:12:22 +0100")

Torsten Bögershausen <tboegi@web.de> writes:

> Especially, what happens if a remote is named with a non-ASCII
> character (unicode code point would be a better term) ?
> To determine the width on screen for aligment, strlen()
> does the wrong thing here.

Interesting point.  I am still skeptical about the patch and suspect
that it is better to stick to easy-to-parse output, but if we switch
to align for humans, we should definitely count display columns, not
byte count with strlen().

Thanks.



  reply	other threads:[~2023-02-08 16:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 23:52 [PATCH] remote: align columns on -v Kir Kolyshkin
2023-02-08 16:12 ` Torsten Bögershausen
2023-02-08 16:32   ` Junio C Hamano [this message]
2023-02-09  1:02   ` Kirill Kolyshkin
2023-02-08 16:19 ` Junio C Hamano
2023-02-09  1:11   ` Kirill Kolyshkin
2023-02-09  1:12 ` Kir Kolyshkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1qn0ungo.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dodin.roman@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kolyshkin@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.