From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Josh Steadmon" <steadmon@google.com>,
"Calvin Wan" <calvinwan@google.com>,
"Emily Shaffer" <emilyshaffer@google.com>,
"Glen Choo" <chooglen@google.com>,
"John Cai" <johncai86@gmail.com>
Subject: Re: [RFC PATCH 1/3] test-tool: don't fake up BUG() exits as code 99
Date: Wed, 08 Jun 2022 14:03:27 -0700 [thread overview]
Message-ID: <xmqq1qvyrhpc.fsf@gitster.g> (raw)
In-Reply-To: <YqD100DRVJoZCC+x@coredump.intra.peff.net> (Jeff King's message of "Wed, 8 Jun 2022 15:17:39 -0400")
Jeff King <peff@peff.net> writes:
> I do agree that an environment variable would be a better selector than
> "this code is linked against test-tool". I thought so even back in:
>
> https://lore.kernel.org/git/20180507090109.GA367@sigill.intra.peff.net/
>
> :) That message also covers the flip-side case discussed earlier in this
> thread: why calling abort() unconditionally in the test suite can be a
> pain.
Nice. Thanks.
next prev parent reply other threads:[~2022-06-08 21:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 0:30 [RFC PATCH 0/3] trace2: log "signal" end events if we invoke BUG() Ævar Arnfjörð Bjarmason
2022-05-26 0:30 ` [RFC PATCH 1/3] test-tool: don't fake up BUG() exits as code 99 Ævar Arnfjörð Bjarmason
2022-06-03 19:25 ` Junio C Hamano
2022-06-03 21:05 ` Junio C Hamano
2022-06-03 23:05 ` Ævar Arnfjörð Bjarmason
2022-06-08 19:17 ` Jeff King
2022-06-08 21:03 ` Junio C Hamano [this message]
2022-06-09 8:09 ` Ævar Arnfjörð Bjarmason
2022-06-09 15:23 ` Jeff King
2022-06-03 23:03 ` Ævar Arnfjörð Bjarmason
2022-05-26 0:30 ` [RFC PATCH 2/3] refs API: rename "abort" callback to avoid macro clash Ævar Arnfjörð Bjarmason
2022-05-26 0:30 ` [RFC PATCH 3/3] trace2: emit "signal" events after calling BUG() Ævar Arnfjörð Bjarmason
2022-05-26 3:04 ` Bagas Sanjaya
2022-05-31 18:16 ` Josh Steadmon
2022-05-26 1:20 ` [RFC PATCH 0/3] trace2: log "signal" end events if we invoke BUG() Junio C Hamano
2022-05-31 17:59 ` Josh Steadmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1qvyrhpc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=calvinwan@google.com \
--cc=chooglen@google.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=johncai86@gmail.com \
--cc=peff@peff.net \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.