From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: git@vger.kernel.org, worldhello.net@gmail.com
Subject: Re: [PATCH v2] l10n: README: call more attention to plural strings
Date: Tue, 21 Dec 2021 12:54:58 -0800 [thread overview]
Message-ID: <xmqq1r25ptjx.fsf@gitster.g> (raw)
In-Reply-To: <a9453065c2e89d79fc117363fe41fa10986e06d1.1640113138.git.steadmon@google.com> (Josh Steadmon's message of "Tue, 21 Dec 2021 11:00:42 -0800")
Josh Steadmon <steadmon@google.com> writes:
> In po/README.md, we point core developers to gettext's "Preparing
> Strings" documentation for advice on marking strings for translation.
> However, this doc doesn't really discuss the issues around plural form
> translation, which can make it seem that nothing special needs to be
> done in this case.
>
> Add a specific callout here about marking plural-form strings so that
> the advice later on in the README is not overlooked.
>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
> po/README.md | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/po/README.md b/po/README.md
> index dcd8436c25..19fabb4acf 100644
> --- a/po/README.md
> +++ b/po/README.md
> @@ -221,6 +221,10 @@ General advice:
> - Adjust the strings so that they're easy to translate. Most of the
> advice in `info '(gettext)Preparing Strings'` applies here.
>
> +- Strings referencing numbers of items may need to be split into singular and
> + plural forms; see the Q\_() wrapper in the C sub-section below for an
> + example.
> +
> - If something is unclear or ambiguous you can use a "TRANSLATORS"
> comment to tell the translators what to make of it. These will be
> extracted by xgettext(1) and put in the "po/\*.po" files, e.g. from
>
> base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc
Looks sensible to me.
I do not mind taking this myself, instead of getting it via our i18n
manager, if Jiang is OK with it.
Thanks.
next prev parent reply other threads:[~2021-12-21 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 19:56 [PATCH] l10n: README: call more attention to plural strings Josh Steadmon
2021-12-13 21:56 ` Junio C Hamano
2021-12-13 22:02 ` Josh Steadmon
2021-12-13 22:18 ` Junio C Hamano
2021-12-16 1:10 ` Jiang Xin
2021-12-21 19:01 ` Josh Steadmon
2021-12-21 19:00 ` [PATCH v2] " Josh Steadmon
2021-12-21 20:54 ` Junio C Hamano [this message]
2021-12-22 1:46 ` Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1r25ptjx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=steadmon@google.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.