From: Junio C Hamano <gitster@pobox.com>
To: Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com>
Cc: Andrew Oakley <andrew@adoakley.name>,
Luke Diamand <luke@diamand.org>, Git List <git@vger.kernel.org>,
Feiyang Xue <me@feiyangxue.com>
Subject: Re: [PATCH 2/2] git-p4: do not decode data from perforce by default
Date: Wed, 05 May 2021 13:34:32 +0900 [thread overview]
Message-ID: <xmqq1ral4x47.fsf@gitster.g> (raw)
In-Reply-To: <CAKu1iLUaLuAZWqjNK4tfhhR=YaSt4MdQ+90ZY-JcEh_SeHyYCw@mail.gmail.com> (Tzadik Vanderhoof's message of "Tue, 4 May 2021 21:02:54 -0700")
Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com> writes:
> On Tue, May 4, 2021 at 6:11 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com> writes:
>>
>> > On Tue, May 4, 2021 at 2:01 PM Andrew Oakley <andrew@adoakley.name> wrote:
>> >> The key thing that I'm trying to point out here is that the encoding is
>> >> not necessarily consistent between different commits. The changes that
>> >> you have proposed force you to pick one encoding that will be used for
>> >> every commit. If it's wrong then data will be corrupted, and there is
>> >> no option provided to avoid that. The only way I can see to avoid this
>> >> issue is to not attempt to re-encode the data - just pass it directly
>> >> to git.
>> > ...
> Are you talking about a scenario where most of the commits are UTF-8,
> one is "cp1252" and another one is "cp1251", so a total of 3 encodings
> are used in the Perforce depot? I don't think that is a common scenario.
Yes. I think that is where "not necessarily consistent between
different commits" leads us to---not limited only to two encodings.
> I agree with the idea that if you know what the encoding is, then
> why not just use that knowledge to convert that to UTF-8, rather
> than use the encoding header.
prev parent reply other threads:[~2021-05-05 4:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 8:52 [PATCH 0/2] git-p4: encoding of data from perforce Andrew Oakley
2021-04-12 8:52 ` [PATCH 1/2] git-p4: avoid decoding more " Andrew Oakley
2021-04-12 8:52 ` [PATCH 2/2] git-p4: do not decode data from perforce by default Andrew Oakley
2021-04-29 10:00 ` Tzadik Vanderhoof
2021-04-30 8:53 ` Andrew Oakley
2021-04-30 15:33 ` Luke Diamand
2021-04-30 18:08 ` Tzadik Vanderhoof
2021-05-04 21:01 ` Andrew Oakley
2021-05-04 21:46 ` Tzadik Vanderhoof
2021-05-05 1:11 ` Junio C Hamano
2021-05-05 4:02 ` Tzadik Vanderhoof
2021-05-05 4:06 ` Tzadik Vanderhoof
2021-05-05 4:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1ral4x47.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=andrew@adoakley.name \
--cc=git@vger.kernel.org \
--cc=luke@diamand.org \
--cc=me@feiyangxue.com \
--cc=tzadik.vanderhoof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.