From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH v1] builtin/pack-objects.c: ignore missing links with --stdin-packs
Date: Fri, 19 Mar 2021 13:55:45 -0700 [thread overview]
Message-ID: <xmqq1rcan9ri.fsf@gitster.g> (raw)
In-Reply-To: <YFT8LqAcCqpG2wyl@coredump.intra.peff.net> (Jeff King's message of "Fri, 19 Mar 2021 15:31:58 -0400")
Jeff King <peff@peff.net> writes:
> If they are truly unreachable, then it is not strictly wrong to delete
> them (i.e., we are not corrupting a repository unless it was already
> corrupted), but:
>
> - if the repository _is_ already corrupted, we are definitely making
> things worse
Yes, that is a reason enough not to eject a commit whose tree is
incomplete.
prev parent reply other threads:[~2021-03-19 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 15:40 [PATCH v1] builtin/pack-objects.c: ignore missing links with --stdin-packs Taylor Blau
2021-03-19 18:19 ` Junio C Hamano
2021-03-19 19:31 ` Jeff King
2021-03-19 20:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rcan9ri.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.