All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Denton Liu <liu.denton@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 5/7] Makefile: add 'check-sort' target
Date: Wed, 17 Mar 2021 11:01:47 -0700	[thread overview]
Message-ID: <xmqq1rcdy7zo.fsf@gitster.g> (raw)
In-Reply-To: <87mtv2dk18.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 17 Mar 2021 13:47:15 +0100")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>> +	./check-sort.perl '\t\{ "[^"]*",' <git.c
>
> This last one you can IMO be done better as (or if we want to be more
> anal, we could make git die on startup if it's not true):
>     
>     diff --git a/t/t0012-help.sh b/t/t0012-help.sh
>     index 5679e29c62..5bd2ebceca 100755
>     --- a/t/t0012-help.sh
>     +++ b/t/t0012-help.sh
>     @@ -77,6 +77,11 @@ test_expect_success 'generate builtin list' '
>             git --list-cmds=builtins >builtins
>      '
>      
>     +test_expect_success 'list of builtins in git.c should be sorted' '
>     +       sort builtins >sorted &&
>     +       test_cmp sorted builtins
>     +'

"LANG=C LC_ALL=C sort ..."

I like this 100% better than the original ;-)

  parent reply	other threads:[~2021-03-17 18:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16  0:56 [PATCH 0/7] Sort lists and add static-analysis Denton Liu
2021-03-16  0:56 ` [PATCH 1/7] Makefile: mark 'check-builtins' as a .PHONY target Denton Liu
2021-03-16  4:59   ` Eric Sunshine
2021-03-17 17:47   ` Junio C Hamano
2021-03-16  0:56 ` [PATCH 2/7] Makefile: ASCII-sort LIB_OBJS Denton Liu
2021-03-16  0:56 ` [PATCH 3/7] builtin.h: ASCII-sort list of functions Denton Liu
2021-03-17 17:51   ` Junio C Hamano
2021-03-16  0:56 ` [PATCH 4/7] test-tool.h: " Denton Liu
2021-03-17 17:54   ` Junio C Hamano
2021-03-16  0:56 ` [PATCH 5/7] Makefile: add 'check-sort' target Denton Liu
2021-03-16  6:37   ` Eric Sunshine
2021-03-17  9:50     ` Denton Liu
2021-03-17 12:47   ` Ævar Arnfjörð Bjarmason
2021-03-17 17:32     ` Jeff King
2021-03-17 17:42       ` Ævar Arnfjörð Bjarmason
2021-03-17 21:48       ` Eric Sunshine
2021-03-17 22:01         ` Jeff King
2021-03-17 18:01     ` Junio C Hamano [this message]
2021-03-17 18:16       ` Ævar Arnfjörð Bjarmason
2021-03-17 17:59   ` Junio C Hamano
2021-03-16  0:56 ` [PATCH 6/7] ci/run-static-analysis.sh: make check-builtins Denton Liu
2021-03-16  0:56 ` [PATCH 7/7] ci/run-static-analysis.sh: make check-sort Denton Liu
2021-03-17 11:01 ` [PATCH 0/7] Sort lists and add static-analysis Bagas Sanjaya
2021-03-17 18:05 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1rcdy7zo.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.