From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Vasco Almeida <vascomalmeida@sapo.pt>
Subject: Re: [RFC] send-email: avoid duplicate In-Reply-To and References headers
Date: Sat, 11 Feb 2017 18:51:17 -0800 [thread overview]
Message-ID: <xmqq1sv4glzu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170212021208.GA16358@starla> (Eric Wong's message of "Sun, 12 Feb 2017 02:12:08 +0000")
Eric Wong <e@80x24.org> writes:
> Junio C Hamano <gitster@pobox.com> wrote:
>>
>> I think it is sensibleto give priority to the --in-reply-to option
>> given from the command line over the in-file one. I am not sure if
>> we want to drop references, though. Wouldn't it make more sense to
>> just add what we got from the command line to what we read from the
>> file? I dunno.
>
> You're right, existing References in the bodies should probably
> be prepended to current ones, as their order should be
> oldest-to-newest.
If you were to go that way, it may also make sense to demote the
original In-Reply-To you find in the file to an entry in the
References list, if it does not already appear there.
I didn't check the RFCs, but I think your original motivation is to
ensure that there is not more than one messages to which the current
message is replying to, iow, to ensure that there is only one message
that is In-Reply-To, so appending would not be a good solution there.
prev parent reply other threads:[~2017-02-12 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 0:34 [RFC] send-email: avoid duplicate In-Reply-To and References headers Eric Wong
2017-02-12 1:41 ` Junio C Hamano
2017-02-12 2:12 ` Eric Wong
2017-02-12 2:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1sv4glzu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=vascomalmeida@sapo.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.